Master breaks on linux / PHP 7.4

[apss-pohl]

Hi,

i just recompiled using the latest master for the first time since a while with the two commits:
some deprecated and inicialization
fixes to force type, as the php-cpp deleted Php::Value(const void*). need tests as explode alot warnings

When i try to start my application it crashes instantly without any output.
Not sure how to investigate but i would suggest to not have them in master for now but rather on a testing branch.

Best regrds,
Sven

[scorninpc]

hello Sven

But why 7.4 ?

maybe we can add a note to checkout this version before compile to 7.4

[apss-pohl]

Hey Bruno,
we will have to keep using 7.4 for a longer time. Therefore i only test 7.4. Is it working fine with php8? Then we should think of creating a branch for php7. I could also do this in my repo.

[scorninpc]

Yeh! oficially the releases are on PHP 8.2.22, Linux and Windows

[apss-pohl]

Hi Bruno,
which cpp do you currently use for compliling? I used the official repo/ maszer
I tried for php 8.4 on linux and it crashes at: Gtk::main();

UPDATE:
I was able to track it down to two events: focus-in-event/focus-out-event

As soon as i remove them from the application it stops crashing. I can reproduce this also with a minimal application like:

$vbox = new GtkBox(GtkOrientation::VERTICAL);
/**
 * START
 */
$button =  GtkButton::new_with_label('new_with_label');
$button2 =  GtkButton::new_with_label('new_with_label2');
$button3 =  GtkButton::new_with_label('new_with_label');
$button4 =  GtkButton::new_with_label('new_with_label2');

$buttonBox = new GtkButtonBox(GtkOrientation::HORIZONTAL);
$buttonBox->set_layout(GtkButtonBoxStyle::CENTER);
$buttonBox->pack_start($button, FALSE, TRUE, 25);
$buttonBox->pack_start($button2, FALSE, TRUE, 25);

$buttonBox2 = new GtkButtonBox(GtkOrientation::VERTICAL);
// $buttonBox->set_child_non_homogeneous(false);
$buttonBox2->pack_start($button3, FALSE, TRUE, 25);
$buttonBox2->pack_start($button4, FALSE, TRUE, 25);

/**
 * END
 */
$vbox->pack_start($buttonBox, FALSE, TRUE, 25);
$vbox->pack_start($buttonBox2, FALSE, TRUE, 25);

$win = new GtkWindow(Gtk::WINDOW_TOPLEVEL);
$win->connect('destroy', array('gtk', 'main_quit'));
$win->set_default_size(300, 400);
$win->set_title("PHP-GTK3");
$win->set_position(Gtk::WIN_POS_CENTER);
$win->set_type_hint(Gdk::WINDOW_TYPE_HINT_NORMAL);
// $win->connect('focus-out-event', function ($ctrl) {
//     $this->outFocus();
// });
// $win->connect('focus-in-event', function ($ctrl) {
//     $this->outFocus();
// });

// Icon from file
$win->set_icon_from_file('.\\logo.png');

$win->add($vbox);

// Show all
$win->show_all();

// Loop
Gtk::main();

I was able to catch a stack trace but tbh i dont understand whats happening:

Thread 1 "php8.4" received signal SIGSEGV, Segmentation fault.
0x00007ffff116a054 in GdkEventButton_::populate(_GdkEventButton) () from /usr/lib/php/20240924/php-gtk3.so
(gdb) bt full
#0  0x00007ffff116a054 in GdkEventButton_::populate(_GdkEventButton) () at /usr/lib/php/20240924/php-gtk3.so
#1  0x00007ffff116a907 in GdkEvent_::populate(_GdkEvent*) () at /usr/lib/php/20240924/php-gtk3.so
#2  0x00007ffff1166b16 in GObject_::connect_callback(void*, ...) () at /usr/lib/php/20240924/php-gtk3.so
#3  0x00007ffff029d0a4 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#4  0x00007ffff13072fa in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5  0x00007ffff133690c in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6  0x00007ffff1326ef2 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7  0x00007ffff13277c1 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#8  0x00007ffff1327883 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9  0x00007ffff0566bf4 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x00007ffff040433f in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x00007ffff0a8a407 in ??? () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#12 0x00007ffff0ae3e2e in ??? () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#13 0x00007ffff0c4b5c5 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#14 0x00007ffff0caa737 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x00007ffff0c4bf87 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x00007ffff03febc5 in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#17 0x00007ffff11854fd in Gtk_::main() () at /usr/lib/php/20240924/php-gtk3.so
#18 0x00007ffff1090885 in void Php::ZendCallable::invoke<&Gtk_::main>(_zend_execute_data*, _zval_struct*) () at /usr/lib/php/20240924/php-gtk3.so
#19 0x0000555555685409 in ??? ()
#20 0x00005555556863dd in ??? ()
#21 0x000055555591bfe1 in zend_execute ()
#22 0x0000555555987586 in zend_execute_script ()
#23 0x0000555555818b48 in php_execute_script_ex ()
#24 0x0000555555989490 in ??? ()
#25 0x000055555568ca33 in ??? ()
#26 0x00007ffff722a1ca in __libc_start_call_main (main=main@entry=0x55555568c6e0, argc=argc@entry=2, argv=argv@entry=0x7fffffffd608) at ../sysdeps/nptl/libc_start_call_main.h:58
        self = <optimized out>
        result = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140737488344584, 2931705727418056853, 2, 0, 93824997606712, 140737354125312, 2931705727445319829, 2931723963446411413}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x2, 0x7fffffffd6--Type <RET> for more, q to quit, c to continue without paging--
00}, data = {prev = 0x0, cleanup = 0x0, canceltype = 2}}}
        not_first_call = <optimized out>
#27 0x00007ffff722a28b in __libc_start_main_impl (main=0x55555568c6e0, argc=2, argv=0x7fffffffd608, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffd5f8) at ../csu/libc-start.c:360
#28 0x000055555568dbb5 in _start ()

[apss-pohl]

Here is an ai generated fix: #184