Skip to content

Drop shadows affecting colour coding of hud lists and gages #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sessile-Nomad opened this issue Apr 12, 2025 · 6 comments · Fixed by #6689
Closed

Drop shadows affecting colour coding of hud lists and gages #6680

Sessile-Nomad opened this issue Apr 12, 2025 · 6 comments · Fixed by #6689
Labels
bug An issue from unintended consequences HUD A feature or issue related to the HUD

Comments

@Sessile-Nomad
Copy link

Using drop shadows seems to remove the colour coding on HUD gauges

Image

Toggling drop shadows off brings the colour coding back

@Goober5000 Goober5000 added bug An issue from unintended consequences HUD A feature or issue related to the HUD labels Apr 12, 2025
@Sessile-Nomad
Copy link
Author

the various gauges are not showing red for enemies, everything is the same colour.
for example - the monitoring list isn't showing red for the Shivans.
EDIT - toggling [drop shadows] in mission had the same result.

@MjnMixael
Copy link
Contributor

When did this issue start? On a specific nightly or has it always been the case?

@Sessile-Nomad
Copy link
Author

Sessile-Nomad commented Apr 16, 2025 via email

@MjnMixael
Copy link
Contributor

So you found this issue one 24.2.0 then and not a recent nightly? That's important clarification because there have been some extensive changes to the HUD code recently.

@Sessile-Nomad
Copy link
Author

Sessile-Nomad commented Apr 16, 2025 via email

@MjnMixael
Copy link
Contributor

I happened to recently do a ton of work in the HUD code so I could immediately see why this happens.

Basically, each gauge's render method sets up everything for the render call and that includes setting the color using a special function to select the color based on gauge settings and that's where using IFF color comes in. Sometime after that is when the gauge will call the render method in hud.cpp, for example HudGauge::renderString().

In the render method is where the dropshadow is handled by first setting the color to black, rendering the string, and then here is where the bug is. It sets the color to gauge_color rather than using the original function to reset the color or some other method of saving the previously set color before flipping to black.

Should be a fairly simple fix, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue from unintended consequences HUD A feature or issue related to the HUD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants