-
Notifications
You must be signed in to change notification settings - Fork 172
Drop shadows affecting colour coding of hud lists and gages #6680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the various gauges are not showing red for enemies, everything is the same colour. |
When did this issue start? On a specific nightly or has it always been the case? |
Hi there. Dunno I’m afraid. I only found out about hud drop shadows being a thing this year so I don’t know if it was an issue before then. I haven’t been using nightlies, just the more recent stable builds. Sorry I can’t be if more help.
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mike Nelson ***@***.***>
Sent: Wednesday, April 16, 2025 3:48:29 PM
To: scp-fs2open/fs2open.github.com ***@***.***>
Cc: Sessile-Nomad ***@***.***>; Author ***@***.***>
Subject: Re: [scp-fs2open/fs2open.github.com] Drop shadows affecting colour coding of hud lists and gages (Issue #6680)
When did this issue start? On a specific nightly or has it always been the case?
—
Reply to this email directly, view it on GitHub<#6680 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANO3RGAEUSUFNT7QHIBUWUL2ZZUT3AVCNFSM6AAAAAB3AM2HYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBZHAZTEMRXGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/7740469?s=20&v=4]MjnMixael left a comment (scp-fs2open/fs2open.github.com#6680)<#6680 (comment)>
When did this issue start? On a specific nightly or has it always been the case?
—
Reply to this email directly, view it on GitHub<#6680 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANO3RGAEUSUFNT7QHIBUWUL2ZZUT3AVCNFSM6AAAAAB3AM2HYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBZHAZTEMRXGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
So you found this issue one 24.2.0 then and not a recent nightly? That's important clarification because there have been some extensive changes to the HUD code recently. |
That’s correct, yes 👍
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mike Nelson ***@***.***>
Sent: Wednesday, April 16, 2025 4:01:31 PM
To: scp-fs2open/fs2open.github.com ***@***.***>
Cc: Sessile-Nomad ***@***.***>; Author ***@***.***>
Subject: Re: [scp-fs2open/fs2open.github.com] Drop shadows affecting colour coding of hud lists and gages (Issue #6680)
So you found this issue one 24.2.0 then and not a recent nightly? That's important clarification because there have been some extensive changes to the HUD code recently.
—
Reply to this email directly, view it on GitHub<#6680 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANO3RGFM6J7BDQS3H7N7QAT2ZZWEXAVCNFSM6AAAAAB3AM2HYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBZHA3TEMZTGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/7740469?s=20&v=4]MjnMixael left a comment (scp-fs2open/fs2open.github.com#6680)<#6680 (comment)>
So you found this issue one 24.2.0 then and not a recent nightly? That's important clarification because there have been some extensive changes to the HUD code recently.
—
Reply to this email directly, view it on GitHub<#6680 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANO3RGFM6J7BDQS3H7N7QAT2ZZWEXAVCNFSM6AAAAAB3AM2HYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBZHA3TEMZTGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I happened to recently do a ton of work in the HUD code so I could immediately see why this happens. Basically, each gauge's render method sets up everything for the render call and that includes setting the color using a special function to select the color based on gauge settings and that's where using IFF color comes in. Sometime after that is when the gauge will call the render method in hud.cpp, for example In the render method is where the dropshadow is handled by first setting the color to black, rendering the string, and then here is where the bug is. It sets the color to Should be a fairly simple fix, I think. |
Using drop shadows seems to remove the colour coding on HUD gauges
Toggling drop shadows off brings the colour coding back
The text was updated successfully, but these errors were encountered: