Skip to content

Commit acd2a0c

Browse files
Remove unused and untested u128/i128 implementations (#737)
Extracted from #736 for ease of review.
1 parent 35b352e commit acd2a0c

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

ceno_zkvm/src/expression.rs

+4-12
Original file line numberDiff line numberDiff line change
@@ -591,17 +591,17 @@ macro_rules! mixed_binop_instances {
591591
mixed_binop_instances!(
592592
Add,
593593
add,
594-
(u8, u16, u32, u64, usize, i8, i16, i32, i64, i128, isize)
594+
(u8, u16, u32, u64, usize, i8, i16, i32, i64, isize)
595595
);
596596
mixed_binop_instances!(
597597
Sub,
598598
sub,
599-
(u8, u16, u32, u64, usize, i8, i16, i32, i64, i128, isize)
599+
(u8, u16, u32, u64, usize, i8, i16, i32, i64, isize)
600600
);
601601
mixed_binop_instances!(
602602
Mul,
603603
mul,
604-
(u8, u16, u32, u64, usize, i8, i16, i32, i64, i128, isize)
604+
(u8, u16, u32, u64, usize, i8, i16, i32, i64, isize)
605605
);
606606

607607
impl<E: ExtensionField> Mul for Expression<E> {
@@ -840,14 +840,6 @@ macro_rules! impl_from_unsigned {
840840
}
841841
impl_from_unsigned!(u8, u16, u32, u64, usize, RAMType, InsnKind);
842842

843-
// Implement From trait for u128 separately since it requires explicit reduction
844-
impl<F: SmallField, E: ExtensionField<BaseField = F>> From<u128> for Expression<E> {
845-
fn from(value: u128) -> Self {
846-
let reduced = value.rem_euclid(F::MODULUS_U64 as u128) as u64;
847-
Expression::Constant(F::from(reduced))
848-
}
849-
}
850-
851843
// Implement From trait for signed types
852844
macro_rules! impl_from_signed {
853845
($($t:ty),*) => {
@@ -861,7 +853,7 @@ macro_rules! impl_from_signed {
861853
)*
862854
};
863855
}
864-
impl_from_signed!(i8, i16, i32, i64, i128, isize);
856+
impl_from_signed!(i8, i16, i32, i64, isize);
865857

866858
impl<E: ExtensionField> Display for Expression<E> {
867859
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {

0 commit comments

Comments
 (0)