Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (8e4ec96) to head (993853d).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   82.57%   82.47%   -0.10%     
==========================================
  Files         185      185              
  Lines       16245    16265      +20     
==========================================
+ Hits        13414    13415       +1     
- Misses       2831     2850      +19     

@PierreBoyeau please provide an update about the use case with 1k samples?

Looks great, thanks for addressing the numpy issue as well. One important comment on why the notebook submodule is deleted, and one minor comment. let me know when i can look again for approval

Hi Justin, I have no idea how I managed to delete .gitmodules, I reverted the change. I also improved the docstring, including adding a comment, to update_sample_info, thanks!

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 1.2.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 c3926eb7a0b83e869d17b5b05fe247aa9bc36019

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #3146: fix: vmap False by default'

4. Push to a named branch:

git push YOURFORK 1.2.x:auto-backport-of-pr-3146-on-1.2.x

5. Create a PR against branch 1.2.x, I would have named this PR:

"Backport PR #3146 on branch 1.2.x (fix: vmap False by default)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.