Skip to content

Fix MonotonicTimestampGenerator test and remove src/timestamp_generator.[cpp/hpp] #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muzarski opened this issue May 6, 2025 · 2 comments
Labels
area/testing Related to unit/integration testing P3 P3 item - no one uses this most probably, but in the end it's better to implement it

Comments

@muzarski
Copy link
Contributor

muzarski commented May 6, 2025

This test implements its custom wrapper over MonotonicTimestampGenerator (defined in src/timestamp_generator.cpp). The wrapper's next() implementation simply appends generated timestamp to vector. This vector is then inspected during the test.

To remove the files mentioned in PR title, we firstly need to implement some testing utility API on rust side which would allow to collect the generated timestamps and inspect them. The test needs to be rewritten using this API.

All this should be done once #295 is merged.

@muzarski muzarski added the area/testing Related to unit/integration testing label May 6, 2025
@muzarski muzarski changed the title Fix MonotonicTimestampGenerator and remove src/timestamp_generator.[cpp/hpp] Fix MonotonicTimestampGenerator test and remove src/timestamp_generator.[cpp/hpp] May 6, 2025
@Lorak-mmk
Copy link
Collaborator

Do we have any integration tests (= tests that connect to DB) written in Rust? Or are all in C++, and only unit tests are in Rust?
I'm asking because maybe it would be easier in such cases to rewrite such test in Rust.

@muzarski
Copy link
Contributor Author

muzarski commented May 6, 2025

Do we have any integration tests (= tests that connect to DB) written in Rust? Or are all in C++, and only unit tests are in Rust? I'm asking because maybe it would be easier in such cases to rewrite such test in Rust.

We don't have any rust integration tests yet.

@dkropachev dkropachev added the P3 P3 item - no one uses this most probably, but in the end it's better to implement it label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to unit/integration testing P3 P3 item - no one uses this most probably, but in the end it's better to implement it
Projects
None yet
Development

No branches or pull requests

3 participants