Skip to content

Commit 221e923

Browse files
committed
tests: rename CassnadraSkip to ScyllaOnly
Name does not reflect logic. This annotation makes test framework to skip all non-scylla backends.
1 parent 9c83913 commit 221e923

File tree

7 files changed

+18
-20
lines changed

7 files changed

+18
-20
lines changed

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/DefaultMetadataTabletMapIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import com.datastax.oss.driver.api.core.metadata.KeyspaceTableNamePair;
1111
import com.datastax.oss.driver.api.core.metadata.Node;
1212
import com.datastax.oss.driver.api.core.metadata.Tablet;
13-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
13+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
1414
import com.datastax.oss.driver.api.testinfra.ScyllaRequirement;
1515
import com.datastax.oss.driver.api.testinfra.ccm.CustomCcmRule;
1616
import com.datastax.oss.driver.api.testinfra.session.SessionRule;
@@ -41,7 +41,7 @@
4141
minOSS = "6.0.0",
4242
minEnterprise = "2024.2",
4343
description = "Needs to support tablets")
44-
@CassandraSkip(description = "Tablets are ScyllaDB-only extension")
44+
@ScyllaOnly(description = "Tablets are ScyllaDB-only extension")
4545
public class DefaultMetadataTabletMapIT {
4646
private static final Logger LOG = LoggerFactory.getLogger(DefaultMetadataTabletMapIT.class);
4747
private static final CustomCcmRule CCM_RULE =

integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/TabletMapSchemaChangesIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import com.datastax.oss.driver.api.core.metadata.Node;
1313
import com.datastax.oss.driver.api.core.metadata.schema.KeyspaceMetadata;
1414
import com.datastax.oss.driver.api.core.metadata.schema.TableMetadata;
15-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
15+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
1616
import com.datastax.oss.driver.api.testinfra.ScyllaRequirement;
1717
import com.datastax.oss.driver.api.testinfra.ccm.CustomCcmRule;
1818
import com.datastax.oss.driver.api.testinfra.session.SessionRule;
@@ -34,7 +34,7 @@
3434
minOSS = "6.0.0",
3535
minEnterprise = "2024.2",
3636
description = "Needs to support tablets")
37-
@CassandraSkip(description = "Tablets are ScyllaDB-only extension")
37+
@ScyllaOnly(description = "Tablets are ScyllaDB-only extension")
3838
// Ensures that TabletMap used by MetadataManager behaves as desired on certain events
3939
public class TabletMapSchemaChangesIT {
4040

integration-tests/src/test/java/com/datastax/oss/driver/core/pool/AdvancedShardAwarenessIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import com.datastax.oss.driver.api.core.config.DefaultDriverOption;
1212
import com.datastax.oss.driver.api.core.config.DriverConfigLoader;
1313
import com.datastax.oss.driver.api.core.session.Session;
14-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
14+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
1515
import com.datastax.oss.driver.api.testinfra.ccm.CustomCcmRule;
1616
import com.datastax.oss.driver.api.testinfra.session.SessionUtils;
1717
import com.datastax.oss.driver.internal.core.pool.ChannelPool;
@@ -38,7 +38,7 @@
3838
import org.junit.runner.RunWith;
3939
import org.slf4j.LoggerFactory;
4040

41-
@CassandraSkip(description = "Advanced shard awareness relies on ScyllaDB's shard aware port")
41+
@ScyllaOnly(description = "Advanced shard awareness relies on ScyllaDB's shard aware port")
4242
@RunWith(DataProviderRunner.class)
4343
public class AdvancedShardAwarenessIT {
4444

integration-tests/src/test/java/com/datastax/oss/driver/mapper/SelectBypassCacheIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import com.datastax.oss.driver.api.mapper.annotations.Mapper;
4040
import com.datastax.oss.driver.api.mapper.annotations.PartitionKey;
4141
import com.datastax.oss.driver.api.mapper.annotations.Select;
42-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
42+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
4343
import com.datastax.oss.driver.api.testinfra.ScyllaRequirement;
4444
import com.datastax.oss.driver.api.testinfra.ccm.CcmRule;
4545
import com.datastax.oss.driver.api.testinfra.session.SessionRule;
@@ -54,7 +54,7 @@
5454
import org.junit.rules.TestRule;
5555

5656
@Category(ParallelizableTests.class)
57-
@CassandraSkip(description = "BYPASS CACHE clause is a ScyllaDB CQL Extension")
57+
@ScyllaOnly(description = "BYPASS CACHE clause is a ScyllaDB CQL Extension")
5858
@ScyllaRequirement(
5959
minOSS = "3.1.0",
6060
minEnterprise = "2020.1.0",

integration-tests/src/test/java/com/datastax/oss/driver/mapper/UsingTimeoutIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import com.datastax.oss.driver.api.mapper.annotations.PartitionKey;
2020
import com.datastax.oss.driver.api.mapper.annotations.Select;
2121
import com.datastax.oss.driver.api.mapper.annotations.Update;
22-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
22+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
2323
import com.datastax.oss.driver.api.testinfra.ScyllaRequirement;
2424
import com.datastax.oss.driver.api.testinfra.ccm.CcmRule;
2525
import com.datastax.oss.driver.api.testinfra.session.SessionRule;
@@ -32,7 +32,7 @@
3232
import org.junit.rules.TestRule;
3333

3434
@Category(ParallelizableTests.class)
35-
@CassandraSkip(description = "USING TIMEOUT is a ScyllaDB CQL Extension")
35+
@ScyllaOnly(description = "USING TIMEOUT is a ScyllaDB CQL Extension")
3636
@ScyllaRequirement(
3737
minOSS = "4.4.0",
3838
minEnterprise = "2022.1.0",

test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/CassandraSkip.java renamed to test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ScyllaOnly.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,9 @@
1818
import java.lang.annotation.Retention;
1919
import java.lang.annotation.RetentionPolicy;
2020

21-
/**
22-
* Annotation for a Class or Method that skips it for Cassandra. If the tests are run against
23-
* Cassandra, the test is skipped.
24-
*/
21+
/** Annotation for a Class or Method that skips for non-Scylla backend. */
2522
@Retention(RetentionPolicy.RUNTIME)
26-
public @interface CassandraSkip {
23+
public @interface ScyllaOnly {
2724
/** @return The description returned if this requirement is not met. */
28-
String description() default "Disabled for Cassandra.";
25+
String description() default "Supported only for Scylla.";
2926
}

test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import com.datastax.oss.driver.api.core.Version;
2929
import com.datastax.oss.driver.api.core.metadata.EndPoint;
3030
import com.datastax.oss.driver.api.testinfra.CassandraResourceRule;
31-
import com.datastax.oss.driver.api.testinfra.CassandraSkip;
31+
import com.datastax.oss.driver.api.testinfra.ScyllaOnly;
3232
import com.datastax.oss.driver.api.testinfra.ScyllaSkip;
3333
import com.datastax.oss.driver.api.testinfra.requirement.BackendRequirementRule;
3434
import com.datastax.oss.driver.api.testinfra.requirement.BackendType;
@@ -87,16 +87,17 @@ public void evaluate() {
8787
}
8888
}
8989

90-
CassandraSkip cassandraSkip = description.getAnnotation(CassandraSkip.class);
91-
if (cassandraSkip != null) {
90+
ScyllaOnly scyllaOnly = description.getAnnotation(ScyllaOnly.class);
91+
if (scyllaOnly != null) {
9292
if (!CcmBridge.isDistributionOf(BackendType.SCYLLA)) {
9393
return new Statement() {
9494

9595
@Override
9696
public void evaluate() {
9797
throw new AssumptionViolatedException(
9898
String.format(
99-
"Test skipped when running with Cassandra. Description: %s", description));
99+
"Test skipped when running against non-scylla backend. Description: %s",
100+
description));
100101
}
101102
};
102103
}

0 commit comments

Comments
 (0)