Improve todo comment in GCPSigner

lukpueh · lukpueh · commit 3574b50e0391 · 2025-03-20T13:23:47.000+01:00
Signed-off-by: Lukas Puehringer &lt;lukas.puehringer@nyu.edu&gt;
diff --git a/securesystemslib/signer/_gcp_signer.py b/securesystemslib/signer/_gcp_signer.py
@@ -180,7 +180,7 @@ def _get_hash_algorithm(public_key: Key) -> str:
             )
 
         # trigger UnsupportedAlgorithm if appropriate
-        # TODO: validate scheme/algo in constructor (#766)
+        # TODO: deduplicate scheme parsing and improve validation (#594, #766)
         try:
             _ = hashlib.new(algo)
         except (ValueError, TypeError) as e:

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ def _get_hash_algorithm(public_key: Key) -> str:`
`180`	`180`	`)`
`181`	`181`
`182`	`182`	`# trigger UnsupportedAlgorithm if appropriate`
`183`		`- # TODO: validate scheme/algo in constructor (#766)`
	`183`	`+ # TODO: deduplicate scheme parsing and improve validation (#594, #766)`
`184`	`184`	`try:`
`185`	`185`	`_ = hashlib.new(algo)`
`186`	`186`	`except (ValueError, TypeError) as e:`