#121 Give Class a More Meaningful Name

Signed-off-by: Sven Strittmatter <[email protected]>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java renamed to src/main/java/io/securecodebox/persistence/defectdojo/http/RestTemplateFactory.java

@@ -13,13 +13,13 @@
 import org.springframework.web.client.RestTemplate;
 
 /**
- * Placeholder to move duplicated code, will be named better later
+ * Factory to create preconfigured {@link RestTemplate}
  */
 @Slf4j
-public final class Foo {
+public final class RestTemplateFactory {
   private final ProxyConfig proxyConfig;
 
-  public Foo(@NonNull ProxyConfig proxyConfig) {
+  public RestTemplateFactory(@NonNull ProxyConfig proxyConfig) {
     super();
     this.proxyConfig = proxyConfig;
   }

src/main/java/io/securecodebox/persistence/defectdojo/service/GenericDefectDojoService.java

@@ -8,7 +8,7 @@
 import io.securecodebox.persistence.defectdojo.config.ClientConfig;
 import io.securecodebox.persistence.defectdojo.exception.TooManyResponsesException;
 import io.securecodebox.persistence.defectdojo.http.AuthHeaderFactory;
-import io.securecodebox.persistence.defectdojo.http.Foo;
+import io.securecodebox.persistence.defectdojo.http.RestTemplateFactory;
 import io.securecodebox.persistence.defectdojo.http.ProxyConfig;
 import io.securecodebox.persistence.defectdojo.http.ProxyConfigFactory;
 import io.securecodebox.persistence.defectdojo.model.Model;
@@ -199,7 +199,8 @@ private HttpHeaders createAuthorizationHeaders() {
   }
 
   private RestTemplate setupRestTemplate() {
-    final RestTemplate template = new Foo(new ProxyConfigFactory().create()).createRestTemplate();
+    final RestTemplate template = new RestTemplateFactory(new ProxyConfigFactory().create()).createRestTemplate();
+    // TODO: Maybe all of this could be moved into the factory.
     final MappingJackson2HttpMessageConverter converter = new MappingJackson2HttpMessageConverter();
     converter.setObjectMapper(mapper.modelObjectMapper());
     template.setMessageConverters(List.of(

src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService2.java

@@ -9,7 +9,7 @@
 import io.securecodebox.persistence.defectdojo.config.ClientConfig;
 import io.securecodebox.persistence.defectdojo.exception.PersistenceException;
 import io.securecodebox.persistence.defectdojo.http.AuthHeaderFactory;
-import io.securecodebox.persistence.defectdojo.http.Foo;
+import io.securecodebox.persistence.defectdojo.http.RestTemplateFactory;
 import io.securecodebox.persistence.defectdojo.http.ProxyConfigFactory;
 import io.securecodebox.persistence.defectdojo.model.ScanFile;
 import lombok.Data;
@@ -54,7 +54,7 @@ private HttpHeaders getDefectDojoAuthorizationHeaders() {
   }
 
   protected RestTemplate setupRestTemplate() {
-    return new Foo(new ProxyConfigFactory().create()).createRestTemplate();
+    return new RestTemplateFactory(new ProxyConfigFactory().create()).createRestTemplate();
   }
 
   /**

src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java renamed to src/test/java/io/securecodebox/persistence/defectdojo/http/RestTemplateFactoryTest.java

@@ -11,16 +11,16 @@
 import static org.junit.jupiter.api.Assertions.assertAll;
 
 /**
- * Tests for {@link Foo}
+ * Tests for {@link RestTemplateFactory}
  */
-class FooTest {
+class RestTemplateFactoryTest {
   private final ProxyConfig proxyConfig = ProxyConfig.builder()
     .user("user")
     .password("pw")
     .host("host")
     .port(42)
     .build();
-  private final Foo sut = new Foo(proxyConfig);
+  private final RestTemplateFactory sut = new RestTemplateFactory(proxyConfig);