Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 491aaff

Browse files
committed
Correct Nmap & Ncrack Version
Nmap & Ncrack have their own Versioning schemes and should not use the chart version but the appVersion. This also corrects a typo in the ci config which build the wrong tag name (missing the `r`).
1 parent 6d1ee24 commit 491aaff

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ jobs:
317317
repository: securecodebox/scanner-nmap
318318
path: ./scanners/nmap/scanner/
319319
# Note: not prefixed with a "v" as this seems to match nmap versioning standards
320-
tags: "7.80,7.80-2,latest"
320+
tags: "7.80,7.80-r2,latest"
321321
- uses: docker/build-push-action@v1
322322
name: "Build & Push kube-hunter Scanner Image"
323323
with:

scanners/ncrack/templates/ncrack-scan-type.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ spec:
1717
restartPolicy: OnFailure
1818
containers:
1919
- name: ncrack
20-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"
20+
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
2121
command: ["ncrack", "-oX", "/home/securecodebox/ncrack-results.xml"]
2222
resources:
2323
{{- toYaml .Values.scannerJob.resources | nindent 16 }}

scanners/nmap/templates/nmap-scan-type.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ spec:
1717
restartPolicy: OnFailure
1818
containers:
1919
- name: nmap
20-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"
20+
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
2121
command: ["nmap", "-oX", "/home/securecodebox/nmap-results.xml"]
2222
resources:
2323
{{- toYaml .Values.scannerJob.resources | nindent 16 }}

0 commit comments

Comments
 (0)