Added various launch safety checks

Author: d2dyno1

Diff for: ClipboardCanvas/App.xaml.cs

@@ -8,7 +8,7 @@
 using CommunityToolkit.Mvvm.DependencyInjection;
 using CommunityToolkit.WinUI.Notifications;
 using ClipboardCanvas.GlobalizationExtensions;
-
+using ClipboardCanvas.Helpers;
 using ClipboardCanvas.Services;
 using ClipboardCanvas.Services.Implementation;
 using Microsoft.AppCenter;
@@ -175,27 +175,7 @@ private void LogException(Exception e, Action tryHandleException = null)
 
         private void LogExceptionToFile(Exception e)
         {
-            string exceptionString = "";
-
-            exceptionString += DateTime.Now.ToString(Constants.FileSystem.EXCEPTION_BLOCK_DATE_FORMAT);
-            exceptionString += "\n";
-            exceptionString += $">>> HRESULT {e.HResult}\n";
-            exceptionString += $">>> MESSAGE {e.Message}\n";
-            exceptionString += $">>> STACKTRACE {e.StackTrace}\n";
-            exceptionString += $">>> INNER {e.InnerException}\n";
-            exceptionString += $">>> SOURCE {e.Source}\n\n";
-
-            ILogger logger;
-            try
-            {
-                logger = Ioc.Default.GetService<ILogger>(); // Try get Ioc logger
-            }
-            catch
-            {
-                logger = new ExceptionToFileLogger(); // Use default logger
-            }
-
-            logger.LogToFile(exceptionString);
+            LoggingHelpers.SafeLogExceptionToFile(e);
         }
 
         private void PushErrorNotification()

Diff for: ClipboardCanvas/ClipboardCanvas.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
-    <TargetFramework>net6.0-windows10.0.19041.0</TargetFramework>
+    <TargetFramework>net6.0-windows10.0.20348.0</TargetFramework>
     <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
     <RootNamespace>ClipboardCanvas</RootNamespace>
     <ApplicationManifest>app.manifest</ApplicationManifest>
@@ -25,6 +25,7 @@
   	<MultilingualFallbackLanguage>en</MultilingualFallbackLanguage>
   	<TranslationReport Condition="'$(Configuration)' == 'Release'">true</TranslationReport>
   	<SuppressPseudoWarning Condition="'$(Configuration)' == 'Debug'">true</SuppressPseudoWarning>
+  	<SupportedOSPlatformVersion>10.0.18362.0</SupportedOSPlatformVersion>
   </PropertyGroup>
   <ItemGroup>
     <None Remove="Pages\MainWindowContentPage.xaml" />

Diff for: ClipboardCanvas/Helpers/InitialApplicationChecksHelpers.cs

@@ -17,61 +17,77 @@ public static class InitialApplicationChecksHelpers
     {
         public static async Task CheckVersionAndShowDialog()
         {
-            IApplicationSettingsService applicationSettings = Ioc.Default.GetService<IApplicationSettingsService>();
-            IApplicationService applicationService = Ioc.Default.GetService<IApplicationService>();
-            IDialogService dialogService = Ioc.Default.GetService<IDialogService>();
+            try
+            {
+                IApplicationSettingsService applicationSettings = Ioc.Default.GetService<IApplicationSettingsService>();
+                IApplicationService applicationService = Ioc.Default.GetService<IApplicationService>();
+                IDialogService dialogService = Ioc.Default.GetService<IDialogService>();
 
-            string lastVersion = applicationSettings.LastVersionNumber;
-            string currentVersion = applicationService.AppVersion;
+                string lastVersion = applicationSettings.LastVersionNumber;
+                string currentVersion = applicationService.AppVersion;
 
-            if (string.IsNullOrEmpty(lastVersion))
-            {
-                // No version yet, Clipboard Canvas is freshly installed
-                // update the version setting with current version
-                applicationSettings.LastVersionNumber = currentVersion;
-            }
-            else
-            {
-                // Compare two versions
-                if (VersionHelpers.IsVersionDifferentThan(lastVersion, currentVersion))
+                if (string.IsNullOrEmpty(lastVersion))
                 {
-                    // Update the last version number to be the current number
+                    // No version yet, Clipboard Canvas is freshly installed
+                    // update the version setting with current version
                     applicationSettings.LastVersionNumber = currentVersion;
+                }
+                else
+                {
+                    // Compare two versions
+                    if (VersionHelpers.IsVersionDifferentThan(lastVersion, currentVersion))
+                    {
+                        // Update the last version number to be the current number
+                        applicationSettings.LastVersionNumber = currentVersion;
 
-                    // Show the update dialog
-                    await dialogService.ShowDialog(new UpdateChangeLogDialogViewModel());
+                        // Show the update dialog
+                        await dialogService.ShowDialog(new UpdateChangeLogDialogViewModel());
+                    }
                 }
             }
+            catch (Exception ex)
+            {
+                LoggingHelpers.SafeLogExceptionToFile(ex);
+            }
         }
 
         public static async Task HandleFileSystemPermissionDialog(IWindowTitleBarControlModel windowTitleBar)
         {
-            IDialogService dialogService = Ioc.Default.GetService<IDialogService>();
-            IApplicationService applicationService = Ioc.Default.GetService<IApplicationService>();
-
-            string testForFolderOnFS = Path.GetFullPath(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
-            SafeWrapper<StorageFolder> testFolderResult = await StorageHelpers.ToStorageItemWithError<StorageFolder>(testForFolderOnFS);
-
-            if (!testFolderResult)
+            try
             {
-                applicationService.IsInRestrictedAccessMode = true;
+                IDialogService dialogService = Ioc.Default.GetService<IDialogService>();
+                IApplicationService applicationService = Ioc.Default.GetService<IApplicationService>();
 
-                DialogResult dialogResult = await dialogService.ShowDialog(new FileSystemAccessDialogViewModel());
+                string testForFolderOnFS =
+                    Path.GetFullPath(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
+                SafeWrapper<StorageFolder> testFolderResult =
+                    await StorageHelpers.ToStorageItemWithError<StorageFolder>(testForFolderOnFS);
 
-                if (dialogResult == DialogResult.Primary)
+                if (!testFolderResult)
                 {
-                    // Restart the app
-                    await CoreApplication.RequestRestartAsync(string.Empty);
+                    applicationService.IsInRestrictedAccessMode = true;
+
+                    DialogResult dialogResult = await dialogService.ShowDialog(new FileSystemAccessDialogViewModel());
+
+                    if (dialogResult == DialogResult.Primary)
+                    {
+                        // Restart the app
+                        await CoreApplication.RequestRestartAsync(string.Empty);
+                    }
+                    else
+                    {
+                        // Continue in Restricted Access
+                        windowTitleBar.IsInRestrictedAccess = true;
+                    }
                 }
                 else
                 {
-                    // Continue in Restricted Access
-                    windowTitleBar.IsInRestrictedAccess = true;
+                    return;
                 }
             }
-            else
+            catch (Exception ex)
             {
-                return;
+                LoggingHelpers.SafeLogExceptionToFile(ex);
             }
         }
     }

Diff for: ClipboardCanvas/Helpers/LoggingHelpers.cs

@@ -0,0 +1,44 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using ClipboardCanvas.Services;
+using ClipboardCanvas.Services.Implementation;
+using CommunityToolkit.Mvvm.DependencyInjection;
+
+namespace ClipboardCanvas.Helpers
+{
+    public static class LoggingHelpers
+    {
+        public static void SafeLogExceptionToFile(Exception ex)
+        {
+            if (ex == null)
+            {
+                return;
+            }
+
+            string exceptionString = "";
+
+            exceptionString += DateTime.Now.ToString(Constants.FileSystem.EXCEPTION_BLOCK_DATE_FORMAT);
+            exceptionString += "\n";
+            exceptionString += $">>> HRESULT {ex.HResult}\n";
+            exceptionString += $">>> MESSAGE {ex.Message}\n";
+            exceptionString += $">>> STACKTRACE {ex.StackTrace}\n";
+            exceptionString += $">>> INNER {ex.InnerException}\n";
+            exceptionString += $">>> SOURCE {ex.Source}\n\n";
+
+            ILogger logger;
+            try
+            {
+                logger = Ioc.Default.GetService<ILogger>(); // Try get Ioc logger
+            }
+            catch
+            {
+                logger = new ExceptionToFileLogger(); // Use default logger
+            }
+
+            logger?.LogToFile(exceptionString);
+        }
+    }
+}

Diff for: ClipboardCanvas/MainWindow.xaml

@@ -5,10 +5,11 @@
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
     xmlns:local="using:ClipboardCanvas"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+    xmlns:pg="using:ClipboardCanvas.Pages"
     xmlns:uc="using:ClipboardCanvas.UserControls"
     xmlns:uc2="using:ClipboardCanvas.UserControls.OOBE"
     mc:Ignorable="d">
 
-    <Frame x:Name="MainWindowFrame" />
+    <pg:MainWindowContentPage x:Name="MainPageHost" />
 
 </Window>

Diff for: ClipboardCanvas/MainWindow.xaml.cs

@@ -22,32 +22,34 @@ public sealed partial class MainWindow : Window
     {
         public static MainWindow Instance;
 
-        public MainWindowContentPage MainWindowContentPage => MainWindowFrame.Content as MainWindowContentPage;
+        public MainWindowContentPage MainWindowContentPage => MainPageHost;
 
         public static ApplicationViewTitleBar TitleBar { get; private set; }
 
         public static CoreApplicationViewTitleBar CoreTitleBar { get; private set; }
 
         public MainWindow()
         {
-            this.InitializeComponent();
             Instance = this;
-            MainWindowFrame.Navigate(typeof(MainWindowContentPage), null, new SuppressNavigationTransitionInfo());
+            this.InitializeComponent();
 
-            Initialize();
+            EnsureSafeInitialization();
         }
 
-        private void Initialize()
+        private void EnsureSafeInitialization()
         {
-            Title = "Clipboard Canvas";
-            ExtendsContentIntoTitleBar = true;
-            SetTitleBar(MainWindowContentPage.WindowTitleBar.DraggableRegion);
-
-            IntPtr hwnd = WinRT.Interop.WindowNative.GetWindowHandle(this);
-            int wndLong = User32.GetWindowLong(hwnd, User32.WindowLongFlags.GWL_STYLE);
-            User32.SetWindowLong(hwnd, User32.WindowLongFlags.GWL_STYLE, wndLong | (int)User32.WindowStyles.WS_SYSMENU);
-
-            ThemeHelper.Initialize();
+            try
+            {
+                Title = "Clipboard Canvas";
+                ExtendsContentIntoTitleBar = true;
+                SetTitleBar(MainWindowContentPage.WindowTitleBar.DraggableRegion);
+
+                ThemeHelper.Initialize();
+            }
+            catch (Exception ex)
+            {
+                LoggingHelpers.SafeLogExceptionToFile(ex);
+            }
         }
     }
 }

Diff for: ClipboardCanvas/Services/Implementation/ApplicationService.cs

@@ -7,6 +7,7 @@
 using Microsoft.UI.Windowing;
 
 using ClipboardCanvas.DataModels;
+using ClipboardCanvas.Helpers;
 
 namespace ClipboardCanvas.Services.Implementation
 {
@@ -36,8 +37,15 @@ public IntPtr GetHwnd(Window wnd)
 
         public ApplicationService()
         {
-            MainWindow.Instance.Activated -= Current_Activated;
-            MainWindow.Instance.Activated += Current_Activated;
+            try
+            {
+                MainWindow.Instance.Activated -= Current_Activated;
+                MainWindow.Instance.Activated += Current_Activated;
+            }
+            catch (Exception ex)
+            {
+                LoggingHelpers.SafeLogExceptionToFile(ex);
+            }
         }
 
         private void Current_Activated(object sender, WindowActivatedEventArgs e)

Diff for: ClipboardCanvas/Services/Implementation/NavigationService.cs

@@ -9,13 +9,15 @@
 using ClipboardCanvas.DisplayFrameEventArgs;
 using ClipboardCanvas.ViewModels.UserControls.Collections;
 
+#nullable enable
+
 namespace ClipboardCanvas.Services.Implementation
 {
     public class NavigationService : INavigationService
     {
-        public Frame DisplayFrame { get; internal set; }
+        public Frame? DisplayFrame { get; internal set; }
 
-        public Func<bool> CheckCollectionAvailabilityBeforePageNavigation { get; internal set; }
+        public Func<bool>? CheckCollectionAvailabilityBeforePageNavigation { get; internal set; }
 
         public DisplayPageType CurrentPage { get; private set; }
 
@@ -39,7 +41,7 @@ public bool OpenNewCanvas(ICollectionModel collection, NavigationTransitionType
             BaseDisplayFrameParameterDataModel navigationParameter = new CanvasPageNavigationParameterModel(collection, (CanvasType)canvasType);
             LastPage = CurrentPage;
             CurrentPage = DisplayPageType.CanvasPage;
-            DisplayFrame.Navigate(typeof(CanvasPage), navigationParameter, transitionType.ToNavigationTransition());
+            DisplayFrame?.Navigate(typeof(CanvasPage), navigationParameter, transitionType.ToNavigationTransition());
 
             OnNavigationFinishedEvent?.Invoke(this, new NavigationFinishedEventArgs(true, null, collection, (CanvasType)canvasType, DisplayPageType.CanvasPage));
 
@@ -53,7 +55,7 @@ public bool OpenCanvasPage(ICollectionModel collection, CollectionItemViewModel
                 canvasType = collection.AssociatedCanvasType;
             }
 
-            if (!CheckCollectionAvailabilityBeforePageNavigation())
+            if (!CheckCollectionAvailabilityBeforePageNavigation?.Invoke() ?? true)
             {
                 OnNavigationFinishedEvent?.Invoke(this, new NavigationFinishedEventArgs(false, null, collection, (CanvasType)canvasType, DisplayPageType.CanvasPage));
                 return false;

Diff for: ClipboardCanvas/ValueConverters/BooleanInvertConverter.cs

@@ -12,7 +12,7 @@ public object Convert(object value, Type targetType, object parameter, string la
                 return false;
             }
 
-            if (parameter is string strParam && strParam.ToLower() == "invert") // For debugging purposes
+            if (parameter is string strParam && strParam.ToLower() == "invert")
             {
                 return boolVal;
             }

Diff for: ClipboardCanvas/ViewModels/UserControls/Autopaste/AutopasteControlViewModel.cs

@@ -21,6 +21,8 @@
 using ClipboardCanvas.ViewModels.UserControls.Autopaste.Rules;
 using ClipboardCanvas.ViewModels.UserControls.Collections;
 
+#nullable enable
+
 namespace ClipboardCanvas.ViewModels.UserControls.Autopaste
 {
     public class AutopasteControlViewModel : ObservableObject, IRuleActions, IDisposable
@@ -137,7 +139,7 @@ public Task Initialize()
         {
             if (!string.IsNullOrEmpty(AutopasteSettingsService.AutopastePath))
             {
-                IAutopasteTarget autopasteTarget = CollectionsWidgetViewModel.FindCollection(AutopasteSettingsService.AutopastePath);
+                var autopasteTarget = CollectionsWidgetViewModel.FindCollection(AutopasteSettingsService.AutopastePath);
                 UpdateTarget(autopasteTarget);
             }
 
@@ -168,7 +170,7 @@ private void AddRuleToRuleset(BaseAutopasteRuleViewModel ruleViewModel)
             _itemAddedInternally = false;
         }
 
-        public void UpdateTarget(IAutopasteTarget autopasteTarget)
+        public void UpdateTarget(IAutopasteTarget? autopasteTarget)
         {
             this.AutopasteTarget = autopasteTarget;
             OnPropertyChanged(nameof(AutopasteTargetName));