Skip to content

Commit f366649

Browse files
committed
fix(pencil): Don't set session on options request
1 parent 81ae5fa commit f366649

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/interceptors/http-server-interceptor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ export default class HttpServerInterceptor extends Interceptor implements IInter
3838

3939
Hook([module], (exports, name, basedir) => {
4040
wrapListener(exports.Server.prototype, 'emit', 'request', (event, req, res) => {
41-
const snuid = v4();
42-
SessionManager.setSession(snuid, { req, res });
4341
if (req.method === 'OPTIONS') {
4442
return true;
4543
}
44+
const snuid = v4();
45+
SessionManager.setSession(snuid, { req, res });
4646
const url = req.url;
4747
const clientIp = clientIpFromRequest(req);
4848
const deviceFP = getDeviceFp(req, this.options);

src/interceptors/https-server-interceptor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ export default class HttpServerInterceptor extends Interceptor implements IInter
3636

3737
Hook([module], (exports, name, basedir) => {
3838
wrapListener(exports.Server.prototype, 'emit', 'request', (event, req, res) => {
39-
const snuid = v4();
40-
SessionManager.setSession(snuid, { req, res });
4139
if (req.method === 'OPTIONS') {
4240
return true;
4341
}
42+
const snuid = v4();
43+
SessionManager.setSession(snuid, { req, res });
4444
const url = req.url;
4545
const clientIp = clientIpFromRequest(req);
4646
const deviceFP = getDeviceFp(req, this.options);

src/session-manager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ export interface Session {
66
}
77

88
export default class SessionManager {
9-
private static lastSession = null;
9+
private static lastSessionId = '';
1010
private static session: Map<string, Session> = new Map<string, Session>();
1111

1212
static getLastSession(): Session {
13-
return SessionManager.lastSession || { req: null, res: null };
13+
return SessionManager.session.get(SessionManager.lastSessionId) || { req: null, res: null };
1414
}
1515

1616
static getSession(id: string): Session {
@@ -23,7 +23,7 @@ export default class SessionManager {
2323
SessionManager.session.set(id, session);
2424

2525
//save last session
26-
SessionManager.lastSession = session;
26+
SessionManager.lastSessionId = id;
2727
}
2828

2929
static cleanSession(id: string) {

0 commit comments

Comments
 (0)