Commit 8dbc244
committed
fix(settings): show the restart modal as soon as network settings save
StatusChecker polls /api/v1/status?checkUpdateAvailable=false, but saving
network settings revalidated /api/v1/status, which is a different SWR key
and nothing subscribes to it. The keys stopped matching in #3137 when the
version check toggle was added, so since then the restart modal has only
appeared on the next sixty second poll or on a fresh page load.
The general settings cypress spec covered this and kept passing because
earlier specs left the restart flag dirty, so the modal was already up when
the spec loaded the page. Cleaning that up in #3368 removed the stale flag
the spec was leaning on and the real gap surfaced.1 parent 85984f7 commit 8dbc244
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
| 179 | + | |
179 | 180 | | |
180 | 181 | | |
181 | 182 | | |
| |||
0 commit comments