Remove package property in manifest and replace with namespace property in android closure of build.gradle.kts files.

Author: didiergarcia

.github/workflows/snapshot.yml

@@ -22,7 +22,7 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-core-
       - name: Publush snapshot to sonatype
-        run: ./gradlew publishToSonatype -x lib:withJavaDoc
+        run: ./gradlew publishToSonatype
         env:
           SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }}
           SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}

lib/build.gradle.kts

@@ -12,6 +12,8 @@ android {
     compileSdk = 33
     buildToolsVersion = "33.0.0"
 
+    namespace = "com.segment.analytics.kotlin.destinations.consent"
+
     defaultConfig {
         multiDexEnabled = true
         minSdk = 24

lib/src/main/AndroidManifest.xml

@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.segment.analytics.kotlin.destinations.consent">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>

lib/src/main/java/com/segment/analytics/kotlin/destinations/consent/Constants.kt

@@ -1,5 +1,4 @@
 package com.segment.analytics.kotlin.destinations.consent
-
 object Constants {
     const val EVENT_SEGMENT_CONSENT_PREFERENCE = "Segment Consent Preference"
     const val CONSENT_SETTINGS_KEY = "consentSettings"

testapp/build.gradle.kts

@@ -6,6 +6,8 @@ plugins {
 android {
     compileSdk = 33
 
+    namespace = "com.segment.analytics.destinations.mydestination.testapp"
+    
     defaultConfig {
         applicationId = "com.segment.analytics.destinations.mydestination.testapp"
         minSdk = 24

testapp/src/main/AndroidManifest.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.segment.analytics.destinations.mydestination.testapp">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <application
         android:allowBackup="true"