Fixing ubuntu version and PR comments

Author: MichaelGHSeg

.github/workflows/build.yml

@@ -10,15 +10,15 @@ on:
 jobs:
   cancel_previous:
     permissions: write-all
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: styfle/[email protected]
         with:
           workflow_id: ${{ github.event.workflow.id }}
 
   build:
     needs: cancel_previous
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
       - uses: actions/checkout@v3

.github/workflows/release.yml

@@ -9,7 +9,7 @@ on:
 jobs:
   release:
     permissions: write-all
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     environment: deployment
 
     steps:

Analytics-CSharp/Segment/Analytics/Utilities/SyncEventPipeline.cs

@@ -71,13 +71,10 @@ public SyncEventPipeline(
         public void Put(RawEvent @event) => _writeChannel.Send(@event);
 
         public void Flush() {
-            FlushEvent flushEvent = new FlushEvent(new SemaphoreSlim(1));
-            // Set it up to be released by Upload
-            flushEvent._semaphore.Wait();
-            _writeChannel.Send(flushEvent);
-            // Wait until the single slot in the semaphore is free. (if it's running!)
             if (Running && !_uploadChannel.isCancelled)
             {
+                FlushEvent flushEvent = new FlushEvent(new SemaphoreSlim(0));
+                _writeChannel.Send(flushEvent);
                 flushEvent._semaphore.Wait(_flushTimeout, _flushCancellationToken);
             }
         } 
@@ -155,7 +152,6 @@ private void Upload() => _analytics.AnalyticsScope.Launch(_analytics.NetworkIODi
                 Analytics.Logger.Log(LogLevel.Debug, message: _logTag + " performing flush");
 
                 await Scope.WithContext(_analytics.FileIODispatcher, async () => await _storage.Rollover());
-                await Task.Delay(1); // The rollover might not quite be done, even 1 ms prevents an empty URL list
 
                 string[] fileUrlList = _storage.Read(StorageConstants.Events).Split(',');
                 foreach (string url in fileUrlList)