Skip to content

Conversation

@danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Nov 13, 2025

[fix]: SDK initialization could fail or remain uninitialized in React 17.

// PR description (Optional)
React 17에서 Initialize 과정에서 제대로 state 변경이 반영이 되질 않아서, 무한 Loading 상태로 보이는 문제입니다.
React 18 19 에서는 발생을 하지 않습니다.

// Footer (Recommended)
Fixes CLNP-7731

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.

Changelogs

  • Fixed a Bug where SDK initialization could fail or remain uninitialized in React 17

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name [email protected], Name2 [email protected]

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 17974db
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6915801bd1c40500099d71aa
😎 Deploy Preview https://deploy-preview-1372--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where SDK initialization could fail or remain uninitialized in React 17, causing an infinite loading state. The issue was caused by a circular state dependency where store state was being read and then unnecessarily written back in the same effect.

Key Changes

  • Removed the storeState useMemo that was creating a circular dependency
  • Removed storeState from the useDeepCompareEffect dependencies and update call
  • Stores are now properly managed exclusively through the useSendbird hook's actions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants