Add audio preview controls to all AudioStream subclasses

Author: seppoday

editor/audio/audio_stream_editor_plugin.cpp

@@ -35,7 +35,6 @@
 #include "editor/editor_string_names.h"
 #include "editor/settings/editor_settings.h"
 #include "editor/themes/editor_scale.h"
-#include "scene/resources/audio_stream_wav.h"
 #include "servers/rendering/rendering_server.h"
 
 // AudioStreamEditor
@@ -75,17 +74,31 @@ void AudioStreamEditor::_notification(int p_what) {
 }
 
 void AudioStreamEditor::_draw_preview() {
+	if (stream.is_null()) {
+		return;
+	}
 	Size2 size = get_size();
 	int width = size.width;
 	if (width <= 0) {
-		return; // No points to draw.
+		return;
+	}
+	if (stream->get_length() <= 0.0f) {
+		const Color col = get_theme_color(SNAME("font_disabled_color"), EditorStringName(Editor));
+		Ref<Font> font = get_theme_font(SNAME("status_source"), EditorStringName(EditorFonts));
+		int font_size = get_theme_font_size(SNAME("status_source_size"), EditorStringName(EditorFonts));
+		_preview->draw_string(font,
+				Point2(8 * EDSCALE, size.height * 0.5f + font_size * 0.25f),
+				TTR("Waveform preview not available"),
+				HORIZONTAL_ALIGNMENT_LEFT, -1, font_size, col);
+		return;
 	}
-
-	Rect2 rect = _preview->get_rect();
-
 	Ref<AudioStreamPreview> preview = AudioStreamPreviewGenerator::get_singleton()->generate_preview(stream);
 	float preview_len = preview->get_length();
 
+	if (preview_len <= 0.0f) {
+		return;
+	}
+
 	Vector<Vector2> points;
 	points.resize(width * 2);
 
@@ -96,8 +109,8 @@ void AudioStreamEditor::_draw_preview() {
 		float min = preview->get_min(ofs, ofs_n) * 0.5 + 0.5;
 
 		int idx = i;
-		points.write[idx * 2 + 0] = Vector2(i + 1, rect.position.y + min * rect.size.y);
-		points.write[idx * 2 + 1] = Vector2(i + 1, rect.position.y + max * rect.size.y);
+		points.write[idx * 2 + 0] = Vector2(i + 1, min * size.height);
+		points.write[idx * 2 + 1] = Vector2(i + 1, max * size.height);
 	}
 
 	Vector<Color> colors = { get_theme_color(SNAME("contrast_color_2"), EditorStringName(Editor)) };
@@ -119,6 +132,9 @@ void AudioStreamEditor::_stream_changed() {
 }
 
 void AudioStreamEditor::_play() {
+	if (stream.is_null() || stream->get_length() <= 0.0f) {
+		return;
+	}
 	if (_player->is_playing()) {
 		_pausing = true;
 		_player->stop();
@@ -152,13 +168,16 @@ void AudioStreamEditor::_on_finished() {
 }
 
 void AudioStreamEditor::_draw_indicator() {
-	if (stream.is_null()) {
-		return;
-	}
-
-	Rect2 rect = _preview->get_rect();
-	float len = stream->get_length();
-	float ofs_x = _current / len * rect.size.width;
+    if (stream.is_null()) {
+        return;
+    }
+    float len = stream->get_length();
+    if (len <= 0.0f) {
+        _current_label->set_text(String::num(_current, 2).pad_decimals(2) + " /");
+        return;
+    }
+    Rect2 rect = _preview->get_rect();
+    float ofs_x = _current / len * rect.size.width;
 	const Color col = get_theme_color(SNAME("accent_color"), EditorStringName(Editor));
 	Ref<Texture2D> icon = get_editor_theme_icon(SNAME("TimelineIndicator"));
 	_indicator->draw_line(Point2(ofs_x, 0), Point2(ofs_x, rect.size.height), col, Math::round(2 * EDSCALE));
@@ -209,8 +228,12 @@ void AudioStreamEditor::set_stream(const Ref<AudioStream> &p_stream) {
 	_player->set_stream(stream);
 	_current = 0;
 
-	String text = String::num(stream->get_length(), 2).pad_decimals(2) + "s";
-	_duration_label->set_text(text);
+	float len = stream->get_length();
+	if (len > 0.0f) {
+		_duration_label->set_text(String::num(len, 2).pad_decimals(2) + "s");
+	} else {
+		_duration_label->set_text(TTR("dynamic"));
+	}
 
 	queue_redraw();
 }
@@ -269,7 +292,7 @@ AudioStreamEditor::AudioStreamEditor() {
 // EditorInspectorPluginAudioStream
 
 bool EditorInspectorPluginAudioStream::can_handle(Object *p_object) {
-	return Object::cast_to<AudioStreamWAV>(p_object) != nullptr;
+	return Object::cast_to<AudioStream>(p_object) != nullptr;
 }
 
 void EditorInspectorPluginAudioStream::parse_begin(Object *p_object) {

modules/vorbis/audio_stream_ogg_vorbis.cpp

@@ -516,7 +516,9 @@ double AudioStreamOggVorbis::get_loop_offset() const {
 }
 
 double AudioStreamOggVorbis::get_length() const {
-	ERR_FAIL_COND_V(packet_sequence.is_null(), 0);
+	if (packet_sequence.is_null()) {
+		return 0;
+	}
 	return packet_sequence->get_length();
 }