Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own parsing of the batch insert/update result set #53

Open
Somnium99 opened this issue Apr 3, 2022 · 1 comment
Open

Own parsing of the batch insert/update result set #53

Somnium99 opened this issue Apr 3, 2022 · 1 comment

Comments

@Somnium99
Copy link

Somnium99 commented Apr 3, 2022

Another thought, the generated keys doesn't really have to be a long. They could be any type. I made it Long to be consistent with updateAndReturnGeneratedKey, but it would perhaps be more useful if it took an Row -> T as a param for mapping the generated keys from the resultset.

Originally posted by @magott in #52 (comment)

This (i.e - adding Row -> T) is actually very useful, instead of just receiving the ids
As a matter of fact, it can save an additional roundtrip to the db, just to get the extra columns from that table that we batch-inserted values to.

If this is something that can be done, I'd be happy to join as a reviewer.

@seratch
Copy link
Owner

seratch commented Apr 3, 2022

As far as I know, the type resolution depends on how each JDBC driver works. If someone can enhance this library without bringing any breaking changes to existing apps, I am fine to have the change in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants