Skip to content

Fixes ClassNotFound Exceptions for primitiv attribute types. Furthermore updates pom.xml to support current maven version. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SvenSchindler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes ClassNotFound Exceptions for primitiv attribute types. Furthermore updates pom.xml to support current maven version. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fe3211
adds support for attributes with primitive data types and updates mav…
Nov 2, 2016
f8606e1
sets correct package name
Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/target
/.idea
*.iml
38 changes: 38 additions & 0 deletions dependency-reduced-pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.archive.jmx</groupId>
<artifactId>cmdline-jmxclient</artifactId>
<version>1</version>
<build>
<plugins>
<plugin>
<artifactId>maven-shade-plugin</artifactId>
<version>2.4.3</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<transformers>
<transformer>
<mainClass>org.archive.jmx.Client</mainClass>
</transformer>
</transformers>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
</plugins>
</build>
</project>

39 changes: 0 additions & 39 deletions maven.xml
View file
Open in desktop

This file was deleted.

48 changes: 48 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?xml version="1.0"?>
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.archive.jmx</groupId>
<artifactId>cmdline-jmxclient</artifactId>
<version>1</version>

<dependencies>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>20.0</version>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>2.4.3</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<transformers>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.archive.jmx.Client</mainClass>
</transformer>
</transformers>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
</plugins>
</build>
</project>
46 changes: 38 additions & 8 deletions src/java/org/archive/jmx/Client.java → src/main/java/org/archive/jmx/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,25 @@
*/
package org.archive.jmx;

import com.google.common.collect.BoundType;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;

import java.io.IOException;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.text.FieldPosition;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
import java.util.Set;
import java.util.*;
import java.util.logging.ConsoleHandler;
import java.util.logging.Handler;
import java.util.logging.LogRecord;
import java.util.logging.Logger;
import java.util.logging.SimpleFormatter;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import javax.management.Attribute;
import javax.management.AttributeList;
Expand All @@ -64,6 +65,8 @@
import javax.management.remote.JMXConnectorFactory;
import javax.management.remote.JMXServiceURL;

import static java.util.stream.Collectors.*;


/**
* A Simple Command-Line JMX Client.
Expand Down Expand Up @@ -651,9 +654,15 @@ protected Object doBeanOperation(MBeanServerConnection mbsc,
: new Object[paraminfosLength];
for (int i = 0; i < paraminfosLength; i++) {
MBeanParameterInfo paraminfo = paraminfos[i];
java.lang.reflect.Constructor c = Class.forName(
paraminfo.getType()).getConstructor(
new Class[] {String.class});
java.lang.reflect.Constructor c;
if (isPrimitive(paraminfo.getType())) {
c = classForPrimitive(paraminfo.getType()).getConstructor(
new Class[]{String.class});
} else {
c = Class.forName(
paraminfo.getType()).getConstructor(
new Class[]{String.class});
}
params[i] =
c.newInstance(new Object[] {parse.getArgs()[i]});
signature[i] = paraminfo.getType();
Expand All @@ -665,6 +674,27 @@ protected Object doBeanOperation(MBeanServerConnection mbsc,
return result;
}

private static ImmutableMap<String, Class> primitivesToWrappers = ImmutableMap.<String, Class>builder().
put("boolean", Boolean.class).
put("byte", Byte.class).
put("char", Character.class).
put("short", Short.class).
put("int", Integer.class).
put("long", Long.class).
put("float", Float.class).
put("doulbe", Double.class).
build();

private static boolean isPrimitive(String type) {
return primitivesToWrappers.entrySet().
stream().map(x -> x.getKey()).
collect(toList()).contains(type);
}

private static Class classForPrimitive(String primitive) {
return primitivesToWrappers.get(primitive);
}

protected String listOptions(MBeanServerConnection mbsc,
ObjectInstance instance)
throws InstanceNotFoundException, IntrospectionException,
Expand Down