Skip to content

Commit ad8db5f

Browse files
committed
refactor(openapi): adjust code
Signed-off-by: Matheus Cruz <[email protected]>
1 parent 37a312d commit ad8db5f

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/OpenAPIExecutor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void init(
7878
.path(ctx.buildPath(withParams.getAdditionalProperties())));
7979

8080
MultivaluedMap<String, Object> queryParams =
81-
ctx.buildQuery(withParams.getAdditionalProperties());
81+
ctx.buildQueryParams(withParams.getAdditionalProperties());
8282
queryParams.forEach(
8383
(key, value) -> {
8484
for (Object o : value) {

impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/OpenAPIOperationContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ public String buildPath(Map<String, Object> replacements) {
3636
String name = parameter.getName();
3737
Object value = replacements.get(name);
3838
if (value != null) {
39-
finalPath = path.replace("{" + name + "}", value.toString());
39+
finalPath = path.replaceAll("\\{\\s*" + name + "\\s*}", value.toString());
4040
}
4141
}
4242
}
4343
return finalPath;
4444
}
4545

46-
public MultivaluedMap<String, Object> buildQuery(Map<String, Object> replacements) {
46+
public MultivaluedMap<String, Object> buildQueryParams(Map<String, Object> replacements) {
4747
MultivaluedMap<String, Object> queryParams = new MultivaluedHashMap<>();
4848
for (Parameter parameter : operation.getParameters()) {
4949
if ("query".equals(parameter.getIn())) {

impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPIWorkflowDefinitionTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.serverlessworkflow.impl.WorkflowModel;
2121
import java.io.IOException;
2222
import java.util.List;
23+
import java.util.Map;
2324
import org.assertj.core.api.Assertions;
2425
import org.junit.jupiter.api.BeforeAll;
2526
import org.junit.jupiter.api.Test;
@@ -45,5 +46,11 @@ void testOpenAPIWorkflowExecution() throws IOException {
4546
.join();
4647

4748
Assertions.assertThat(model.asCollection()).isNotEmpty();
49+
Assertions.assertThat(model.asCollection())
50+
.allMatch(
51+
m -> {
52+
Map<String, Object> pet = m.asMap().orElseThrow(RuntimeException::new);
53+
return pet.get("status").equals("available");
54+
});
4855
}
4956
}

0 commit comments

Comments
 (0)