fix(SDK): Fixed AuthenticationSchemeDefinitions by removing required properties, which was resulting in ASP.NET Core incorrectly invalidating posted models

Signed-off-by: Charles d'Avernas <[email protected]>

Author: cdavernas

src/ServerlessWorkflow.Sdk/Models/Authentication/BasicAuthenticationSchemeDefinition.cs

@@ -29,12 +29,12 @@ public record BasicAuthenticationSchemeDefinition
     /// Gets/sets the username used for authentication
     /// </summary>
     [DataMember(Name = "username", Order = 1), JsonPropertyName("username"), JsonPropertyOrder(1), YamlMember(Alias = "username", Order = 1)]
-    public required virtual string Username { get; set; }
+    public virtual string Username { get; set; } = null!;
 
     /// <summary>
     /// Gets/sets the password used for authentication
     /// </summary>
     [DataMember(Name = "password", Order = 2), JsonPropertyName("password"), JsonPropertyOrder(2), YamlMember(Alias = "password", Order = 2)]
-    public required virtual string Password { get; set; }
+    public virtual string Password { get; set; } = null!;
 
 }

src/ServerlessWorkflow.Sdk/Models/Authentication/BearerAuthenticationSchemeDefinition.cs

@@ -29,6 +29,6 @@ public record BearerAuthenticationSchemeDefinition
     /// Gets/sets the bearer token used for authentication
     /// </summary>
     [DataMember(Name = "token", Order = 1), JsonPropertyName("token"), JsonPropertyOrder(1), YamlMember(Alias = "token", Order = 1)]
-    public required virtual string Token { get; set; }
+    public virtual string Token { get; set; } = null!;
 
 }

src/ServerlessWorkflow.Sdk/Models/Authentication/DigestAuthenticationSchemeDefinition.cs

@@ -29,12 +29,12 @@ public record DigestAuthenticationSchemeDefinition
     /// Gets/sets the username used for authentication
     /// </summary>
     [DataMember(Name = "username", Order = 1), JsonPropertyName("username"), JsonPropertyOrder(1), YamlMember(Alias = "username", Order = 1)]
-    public required virtual string Username { get; set; }
+    public virtual string Username { get; set; } = null!;
 
     /// <summary>
     /// Gets/sets the password used for authentication
     /// </summary>
     [DataMember(Name = "password", Order = 2), JsonPropertyName("password"), JsonPropertyOrder(2), YamlMember(Alias = "password", Order = 2)]
-    public required virtual string Password { get; set; }
+    public virtual string Password { get; set; } = null!;
 
 }

src/ServerlessWorkflow.Sdk/Models/Authentication/OAuth2AuthenticationSchemeDefinitionBase.cs

@@ -25,13 +25,13 @@ public abstract record OAuth2AuthenticationSchemeDefinitionBase
     /// Gets/sets the uri that references the OAUTH2 authority to use
     /// </summary>
     [DataMember(Name = "authority", Order = 1), JsonPropertyName("authority"), JsonPropertyOrder(1), YamlMember(Alias = "authority", Order = 1)]
-    public required virtual Uri Authority { get; set; }
+    public virtual Uri? Authority { get; set; }
 
     /// <summary>
     /// Gets/sets the grant type to use. See <see cref="OAuth2GrantType"/>
     /// </summary>
     [DataMember(Name = "grant", Order = 2), JsonPropertyName("grant"), JsonPropertyOrder(2), YamlMember(Alias = "grant", Order = 2)]
-    public required virtual string Grant { get; set; }
+    public virtual string? Grant { get; set; }
 
     /// <summary>
     /// Gets/sets the definition of the client to use

src/ServerlessWorkflow.Sdk/Models/AuthenticationPolicyDefinition.cs

@@ -27,7 +27,7 @@ public record AuthenticationPolicyDefinition
     /// Gets the configured authentication scheme
     /// </summary>
     [IgnoreDataMember, JsonIgnore, YamlIgnore]
-    public virtual string Scheme => this.Basic?.Scheme ?? this.Bearer?.Scheme ?? this.OAuth2?.Scheme ?? throw new NullReferenceException();
+    public virtual string Scheme => this.Basic?.Scheme ?? this.Bearer?.Scheme ?? this.Certificate?.Scheme ?? this.Digest?.Scheme ?? this.OAuth2?.Scheme ?? this.Oidc?.Scheme ?? throw new NullReferenceException();
 
     /// <summary>
     /// Gets/sets the name of the top level authentication policy to use, if any

src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj

@@ -36,7 +36,7 @@
     <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.9.2" />
 	<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
 	<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.0" />
-    <PackageReference Include="Neuroglia.Serialization.YamlDotNet" Version="4.15.0" />
+    <PackageReference Include="Neuroglia.Serialization.YamlDotNet" Version="4.15.3" />
     <PackageReference Include="Semver" Version="2.3.0" />
   </ItemGroup>
 

tests/ServerlessWorkflow.Sdk.UnitTests/Cases/IO/WorkflowDefinitionIOTests.cs

@@ -12,7 +12,6 @@
 // limitations under the License.
 
 using ServerlessWorkflow.Sdk.IO;
-using ServerlessWorkflow.Sdk.Models.Calls;
 
 namespace ServerlessWorkflow.Sdk.UnitTests.Cases.IO;