fix(Sdk): Fixed the condition under which the CallTaskDefinitionValidator validates called functions

cdavernas · cdavernas · commit eb9c1e3611c3 · 2024-10-18T15:39:14.000+02:00
Signed-off-by: Charles d'Avernas &lt;charles.davernas@neuroglia.io&gt;
diff --git a/src/ServerlessWorkflow.Sdk.Builders/ServerlessWorkflow.Sdk.Builders.csproj b/src/ServerlessWorkflow.Sdk.Builders/ServerlessWorkflow.Sdk.Builders.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha3.1</VersionSuffix>
+	<VersionSuffix>alpha4</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
diff --git a/src/ServerlessWorkflow.Sdk.IO/ServerlessWorkflow.Sdk.IO.csproj b/src/ServerlessWorkflow.Sdk.IO/ServerlessWorkflow.Sdk.IO.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha3.1</VersionSuffix>
+	<VersionSuffix>alpha4</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
diff --git a/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj b/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha3.1</VersionSuffix>
+	<VersionSuffix>alpha4</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
diff --git a/src/ServerlessWorkflow.Sdk/Validation/CallTaskDefinitionValidator.cs b/src/ServerlessWorkflow.Sdk/Validation/CallTaskDefinitionValidator.cs
@@ -35,7 +35,7 @@ public CallTaskDefinitionValidator(IServiceProvider serviceProvider, ComponentDe
         this.Components = components;
         this.RuleFor(c => c.Call)
             .Must(ReferenceAnExistingFunction)
-            .When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _) || c.Call.Contains('@'))
+            .When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _) && !c.Call.Contains('@'))
             .WithMessage(ValidationErrors.UndefinedFunction);
         this.When(c => c.Call == Function.AsyncApi, () =>
         {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public CallTaskDefinitionValidator(IServiceProvider serviceProvider, ComponentDe`
`35`	`35`	`this.Components = components;`
`36`	`36`	`this.RuleFor(c => c.Call)`
`37`	`37`	`.Must(ReferenceAnExistingFunction)`
`38`		`- .When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _) \|\| c.Call.Contains('@'))`
	`38`	`+ .When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _) && !c.Call.Contains('@'))`
`39`	`39`	`.WithMessage(ValidationErrors.UndefinedFunction);`
`40`	`40`	`this.When(c => c.Call == Function.AsyncApi, () =>`
`41`	`41`	`{`