Make RefsToEntityQueryCache static

Author: SergeiPavlov

Orm/Xtensive.Orm/Orm/Internals/Prefetch/EntityGroupTask.cs

@@ -128,7 +128,7 @@ private QueryTask CreateQueryTask(List<Tuple> currentKeySet)
       var parameterContext = new ParameterContext();
       parameterContext.SetValue(includeParameter, currentKeySet);
       var session = manager.Owner.Session;
-      Provider = StorageNode.EntityFetchQueryCache.GetOrAdd(cacheKey, CreateRecordSet);
+      Provider = StorageNode.EntityFetchQueryCache.GetOrAdd(cacheKey, static k => CreateRecordSet(k));
       if (session.Domain.TagsEnabled && session.Tags != null) {
         foreach (var tag in session.Tags) {
           Provider = new TagProvider(Provider, tag);

Orm/Xtensive.Orm/Orm/Internals/Prefetch/EntitySetTask.cs

@@ -168,7 +168,7 @@ private QueryTask CreateQueryTask()
 
       var session = manager.Owner.Session;
       var scope = new CompiledQueryProcessingScope(null, null, parameterContext, false);
-      QueryProvider = StorageNode.EntitySetFetchQueryCache.GetOrAdd(cacheKey, CreateRecordSetLoadingItems);
+      QueryProvider = StorageNode.EntitySetFetchQueryCache.GetOrAdd(cacheKey, static k => CreateRecordSetLoadingItems(k));
       if (session.Domain.TagsEnabled && session.Tags != null) {
         foreach (var tag in session.Tags) {
           QueryProvider = new TagProvider(QueryProvider, tag);

Orm/Xtensive.Orm/Orm/Providers/SessionHandler.References.cs

@@ -29,7 +29,7 @@ public virtual IEnumerable<ReferenceInfo> GetReferencesTo(Entity target, Associa
     {
       if (association.IsPaired)
         return FindReferences(target, association, true);
-      var (recordSet, parameter) = Session.StorageNode.RefsToEntityQueryCache .GetOrAdd(association, BuildReferencingQuery);
+      var (recordSet, parameter) = StorageNode.RefsToEntityQueryCache.GetOrAdd(association, static k => BuildReferencingQuery(k));
       var parameterContext = new ParameterContext();
       parameterContext.SetValue(parameter, target.Key.Value);
       ExecutableProvider executableProvider = Session.Compile(recordSet);

Orm/Xtensive.Orm/Orm/StorageNode.cs

@@ -4,11 +4,7 @@
 // Created by: Denis Krjuchkov
 // Created:    2014.03.13
 
-using System;
 using System.Collections.Concurrent;
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using Xtensive.Core;
 using Xtensive.Orm.Configuration;
 using Xtensive.Orm.Interfaces;
@@ -31,7 +27,7 @@ public sealed class StorageNode : ISessionSource
     /// <summary>
     /// Gets node identifier.
     /// </summary>
-    public string Id { get { return Configuration.NodeId; } }
+    public string Id => Configuration.NodeId;
 
     /// <summary>
     /// Gets node configuration.
@@ -71,7 +67,7 @@ public sealed class StorageNode : ISessionSource
     /// <summary>
     /// Caches queries that get references to entities for certain association.
     /// </summary>
-    internal ConcurrentDictionary<AssociationInfo, (CompilableProvider, Parameter<Xtensive.Tuples.Tuple>)> RefsToEntityQueryCache { get; } = new();
+    internal static ConcurrentDictionary<AssociationInfo, (CompilableProvider, Parameter<Xtensive.Tuples.Tuple>)> RefsToEntityQueryCache { get; } = new();
     internal ConcurrentDictionary<SequenceInfo, CachingSequence> KeySequencesCache { get; } = new();
     internal ConcurrentDictionary<PersistRequestBuilderTask, IReadOnlyList<PreparedPersistRequest>> PersistRequestCache { get; } = new();