Add .IsNullOrEmpty(this string) extension for static-typing efficiency (#336)

* Add `internal IsNullOrEmpty(this string)` extension for efficiency

* Formatting

* Use non-public methods too

* Modify IssueJira0627_PocoClassPropertyRenitialization test

* Fix string.IsNullOrEmpty()

* Fix string.IsNullOrEmpty()

Author: SergeiPavlov

Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfiguration.cs

@@ -146,7 +146,7 @@ public static LocalizationConfiguration Load(IConfiguration configuration, strin
         return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
       }
       else if (configuration is IConfigurationSection configurationSection) {
-        return sectionName.IsNullOrEmpty()
+        return string.IsNullOrEmpty(sectionName)
           ? new LocalizationConfigurationReader().Read(configurationSection)
           : new LocalizationConfigurationReader().Read(configurationSection.GetSection(sectionName));
       }

Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfigurationReader.cs

@@ -52,7 +52,7 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati
           }
         }
       }
-      if(!cultureName.IsNullOrEmpty()) {
+      if(!string.IsNullOrEmpty(cultureName)) {
         try {
           defaultCulture = CultureInfo.GetCultureInfo(cultureName);
         }
@@ -64,4 +64,4 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati
       return new LocalizationConfiguration() { DefaultCulture = defaultCulture };
     }
   }
-}
+}

Extensions/Xtensive.Orm.Security/Configuration/SecurityConfigurationReaders.cs

@@ -68,11 +68,11 @@ protected override SecurityConfiguration ReadInternal(IConfigurationSection conf
       }
       if ((hashingServiceName ?? authenticationServiceName) != null) {
         var securityConfiguration = new SecurityConfiguration(true);
-        if (!hashingServiceName.IsNullOrEmpty()) {
+        if (!string.IsNullOrEmpty(hashingServiceName)) {
           securityConfiguration.HashingServiceName = hashingServiceName.ToLowerInvariant();
         }
 
-        if (!authenticationServiceName.IsNullOrEmpty()) {
+        if (!string.IsNullOrEmpty(authenticationServiceName)) {
           securityConfiguration.AuthenticationServiceName = authenticationServiceName.ToLowerInvariant();
         }
 

Orm/Xtensive.Orm.Oracle/Sql.Drivers.Oracle/v09/Compiler.cs

@@ -292,7 +292,7 @@ public override void Visit(SqlFastFirstRowsHint node) =>
 
     public override void Visit(SqlForceJoinOrderHint node)
     {
-      if (node.Tables.IsNullOrEmpty()) {
+      if (!(node.Tables?.Count > 0)) {
         _ = context.Output.Append("ORDERED");
       }
       else {
@@ -583,4 +583,4 @@ protected internal Compiler(SqlDriver driver)
     {
     }
   }
-}
+}

Orm/Xtensive.Orm.Tests/Issues/IssueJira0627_PocoClassPropertyRenitialization.cs

@@ -1133,7 +1133,7 @@ public void AllByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1144,7 +1144,7 @@ public void AllByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1155,7 +1155,7 @@ public void AllByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1166,7 +1166,7 @@ public void AllByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = Assert.Throws<QueryTranslationException>(() => session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty()));
+          .All(el => string.IsNullOrEmpty(el.Name)));
       }
     }
 
@@ -1177,7 +1177,7 @@ public void AllByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1189,7 +1189,7 @@ public void AnyByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1200,7 +1200,7 @@ public void AnyByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1211,7 +1211,7 @@ public void AnyByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Any(el => el.BaseName.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1222,7 +1222,7 @@ public void AnyByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .Any(el => el.BaseName.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1233,7 +1233,7 @@ public void AnyByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1347,7 +1347,7 @@ public void CountByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1358,7 +1358,7 @@ public void CountByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1369,7 +1369,7 @@ public void CountByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Count(el => el.BaseName.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1380,7 +1380,7 @@ public void CountByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .Count(el => el.BaseName.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1391,7 +1391,7 @@ public void CountByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 

Orm/Xtensive.Orm/Core/Extensions/EnumerableExtensions.cs

@@ -25,6 +25,9 @@ public static class EnumerableExtensions
     private const int defaultMaximalBatchSize = 1024;
     private const int defaultFirstFastCount = 0;
 
+    [Obsolete("Use string.IsNullOrEmpty()")]
+    internal static bool IsNullOrEmpty(this string s) => string.IsNullOrEmpty(s);
+
     /// <summary>
     /// Indicates whether enumerable is empty or not
     /// by attempting to cast it to <see cref="ICollection{T}"/> and <see cref="IQueryable{T}"/>.
@@ -35,7 +38,7 @@ public static class EnumerableExtensions
     /// <returns><see langword="True"/> if collection is definitely <see langword="null"/> or empty;
     /// otherwise, <see langword="false"/>.</returns>
     [Obsolete("Don't use Xtensive.Core for 'collection is empty' checking")]
-    public static bool IsNullOrEmpty<TItem>(this IEnumerable<TItem> items)
+    internal static bool IsNullOrEmpty<TItem>(this IEnumerable<TItem> items)
     {
       if (items==null)
         return true;

Orm/Xtensive.Orm/Orm/Linq/MemberCompilation/MemberCompilerProvider.cs

@@ -184,7 +184,7 @@ private static (MemberInfo targetMember, Delegate compilerInvoker) ProcessCompil
             Strings.ExCompilerXHasInvalidTargetType, compiler.GetFullName(true)));
 
       var parameterTypes = ValidateCompilerParametersAndExtractTargetSignature(compiler, isGeneric);
-      var bindingFlags = BindingFlags.Public;
+      var bindingFlags = BindingFlags.Public | BindingFlags.NonPublic;
 
       if (isCtor)
         bindingFlags |= BindingFlags.Instance;

Orm/Xtensive.Orm/Sql/Dml/Hints/SqlForceJoinOrderHint.cs

@@ -12,16 +12,14 @@ namespace Xtensive.Sql.Dml
   [Serializable]
   public class SqlForceJoinOrderHint : SqlHint
   {
-    private SqlTable[] tables;
-
     /// <summary>
     /// Gets the corresponding tables.
     /// </summary>
-    public IEnumerable<SqlTable> Tables { get { return tables; } }
+    public IReadOnlyList<SqlTable> Tables { get; }
 
     internal override SqlForceJoinOrderHint Clone(SqlNodeCloneContext? context = null) =>
       context.GetOrAdd(this, static (t, c) =>
-        new(t.tables?.Select(table => table.Clone()).ToArray(t.tables.Length)));
+        new(t.Tables?.Select(table => table.Clone()).ToArray(t.Tables.Count)));
 
     public override void AcceptVisitor(ISqlVisitor visitor)
     {
@@ -36,7 +34,7 @@ internal SqlForceJoinOrderHint()
 
     internal SqlForceJoinOrderHint(SqlTable[] tables)
     {
-      this.tables = tables;
+      Tables = tables;
     }
   }
 }