Add .IsNullOrEmpty(this string) extension for static-typing efficiency (#336)

SergeiPavlov · web-flow · commit cfa9916b1cd7 · 2025-01-15T02:48:55.000-08:00
* Add `internal IsNullOrEmpty(this string)` extension for efficiency

* Formatting

* Use non-public methods too

* Modify IssueJira0627_PocoClassPropertyRenitialization test

* Fix string.IsNullOrEmpty()

* Fix string.IsNullOrEmpty()
diff --git a/Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfiguration.cs b/Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfiguration.cs
@@ -146,7 +146,7 @@ public static LocalizationConfiguration Load(IConfiguration configuration, strin
         return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
       }
       else if (configuration is IConfigurationSection configurationSection) {
-        return sectionName.IsNullOrEmpty()
+        return string.IsNullOrEmpty(sectionName)
           ? new LocalizationConfigurationReader().Read(configurationSection)
           : new LocalizationConfigurationReader().Read(configurationSection.GetSection(sectionName));
       }
diff --git a/Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfigurationReader.cs b/Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfigurationReader.cs
@@ -52,7 +52,7 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati
           }
         }
       }
-      if(!cultureName.IsNullOrEmpty()) {
+      if(!string.IsNullOrEmpty(cultureName)) {
         try {
           defaultCulture = CultureInfo.GetCultureInfo(cultureName);
         }
@@ -64,4 +64,4 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati
       return new LocalizationConfiguration() { DefaultCulture = defaultCulture };
     }
   }
-}
+}
diff --git a/Extensions/Xtensive.Orm.Security/Configuration/SecurityConfigurationReaders.cs b/Extensions/Xtensive.Orm.Security/Configuration/SecurityConfigurationReaders.cs
@@ -68,11 +68,11 @@ protected override SecurityConfiguration ReadInternal(IConfigurationSection conf
       }
       if ((hashingServiceName ?? authenticationServiceName) != null) {
         var securityConfiguration = new SecurityConfiguration(true);
-        if (!hashingServiceName.IsNullOrEmpty()) {
+        if (!string.IsNullOrEmpty(hashingServiceName)) {
           securityConfiguration.HashingServiceName = hashingServiceName.ToLowerInvariant();
         }
 
-        if (!authenticationServiceName.IsNullOrEmpty()) {
+        if (!string.IsNullOrEmpty(authenticationServiceName)) {
           securityConfiguration.AuthenticationServiceName = authenticationServiceName.ToLowerInvariant();
         }
 
diff --git a/Orm/Xtensive.Orm.Oracle/Sql.Drivers.Oracle/v09/Compiler.cs b/Orm/Xtensive.Orm.Oracle/Sql.Drivers.Oracle/v09/Compiler.cs
@@ -292,7 +292,7 @@ public override void Visit(SqlFastFirstRowsHint node) =>
 
     public override void Visit(SqlForceJoinOrderHint node)
     {
-      if (node.Tables.IsNullOrEmpty()) {
+      if (!(node.Tables?.Count > 0)) {
         _ = context.Output.Append("ORDERED");
       }
       else {
@@ -583,4 +583,4 @@ protected internal Compiler(SqlDriver driver)
     {
     }
   }
-}
+}
diff --git a/Orm/Xtensive.Orm.Tests/Issues/IssueJira0627_PocoClassPropertyRenitialization.cs b/Orm/Xtensive.Orm.Tests/Issues/IssueJira0627_PocoClassPropertyRenitialization.cs
@@ -1133,7 +1133,7 @@ public void AllByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1144,7 +1144,7 @@ public void AllByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1155,7 +1155,7 @@ public void AllByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1166,7 +1166,7 @@ public void AllByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = Assert.Throws<QueryTranslationException>(() => session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .All(el => el.Name.IsNullOrEmpty()));
+          .All(el => string.IsNullOrEmpty(el.Name)));
       }
     }
 
@@ -1177,7 +1177,7 @@ public void AllByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .All(el => el.Name.IsNullOrEmpty());
+          .All(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1189,7 +1189,7 @@ public void AnyByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1200,7 +1200,7 @@ public void AnyByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1211,7 +1211,7 @@ public void AnyByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Any(el => el.BaseName.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1222,7 +1222,7 @@ public void AnyByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .Any(el => el.BaseName.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1233,7 +1233,7 @@ public void AnyByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .Any(el => el.Name.IsNullOrEmpty());
+          .Any(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1347,7 +1347,7 @@ public void CountByFieldOfPoco01Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name })
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1358,7 +1358,7 @@ public void CountByFieldOfPoco02Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
@@ -1369,7 +1369,7 @@ public void CountByFieldOfPoco03Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { Name = e.Name, BaseName = e.Name })
-          .Count(el => el.BaseName.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1380,7 +1380,7 @@ public void CountByFieldOfPoco04Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco { BaseName = e.Name })
-          .Count(el => el.BaseName.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.BaseName));
       }
     }
 
@@ -1391,7 +1391,7 @@ public void CountByFieldOfPoco05Test()
       using (var transaction = session.OpenTransaction()) {
         _ = session.Query.All<TestEntity>()
           .Select(e => new Poco())
-          .Count(el => el.Name.IsNullOrEmpty());
+          .Count(el => string.IsNullOrEmpty(el.Name));
       }
     }
 
diff --git a/Orm/Xtensive.Orm/Core/Extensions/EnumerableExtensions.cs b/Orm/Xtensive.Orm/Core/Extensions/EnumerableExtensions.cs
@@ -25,6 +25,9 @@ public static class EnumerableExtensions
     private const int defaultMaximalBatchSize = 1024;
     private const int defaultFirstFastCount = 0;
 
+    [Obsolete("Use string.IsNullOrEmpty()")]
+    internal static bool IsNullOrEmpty(this string s) => string.IsNullOrEmpty(s);
+
     /// <summary>
     /// Indicates whether enumerable is empty or not
     /// by attempting to cast it to <see cref="ICollection{T}"/> and <see cref="IQueryable{T}"/>.
@@ -35,7 +38,7 @@ public static class EnumerableExtensions
     /// <returns><see langword="True"/> if collection is definitely <see langword="null"/> or empty;
     /// otherwise, <see langword="false"/>.</returns>
     [Obsolete("Don't use Xtensive.Core for 'collection is empty' checking")]
-    public static bool IsNullOrEmpty<TItem>(this IEnumerable<TItem> items)
+    internal static bool IsNullOrEmpty<TItem>(this IEnumerable<TItem> items)
     {
       if (items==null)
         return true;
diff --git a/Orm/Xtensive.Orm/Orm/Linq/MemberCompilation/MemberCompilerProvider.cs b/Orm/Xtensive.Orm/Orm/Linq/MemberCompilation/MemberCompilerProvider.cs
@@ -184,7 +184,7 @@ private static (MemberInfo targetMember, Delegate compilerInvoker) ProcessCompil
             Strings.ExCompilerXHasInvalidTargetType, compiler.GetFullName(true)));
 
       var parameterTypes = ValidateCompilerParametersAndExtractTargetSignature(compiler, isGeneric);
-      var bindingFlags = BindingFlags.Public;
+      var bindingFlags = BindingFlags.Public | BindingFlags.NonPublic;
 
       if (isCtor)
         bindingFlags |= BindingFlags.Instance;
diff --git a/Orm/Xtensive.Orm/Sql/Dml/Hints/SqlForceJoinOrderHint.cs b/Orm/Xtensive.Orm/Sql/Dml/Hints/SqlForceJoinOrderHint.cs
@@ -12,16 +12,14 @@ namespace Xtensive.Sql.Dml
   [Serializable]
   public class SqlForceJoinOrderHint : SqlHint
   {
-    private SqlTable[] tables;
-
     /// <summary>
     /// Gets the corresponding tables.
     /// </summary>
-    public IEnumerable<SqlTable> Tables { get { return tables; } }
+    public IReadOnlyList<SqlTable> Tables { get; }
 
     internal override SqlForceJoinOrderHint Clone(SqlNodeCloneContext? context = null) =>
       context.GetOrAdd(this, static (t, c) =>
-        new(t.tables?.Select(table => table.Clone()).ToArray(t.tables.Length)));
+        new(t.Tables?.Select(table => table.Clone()).ToArray(t.Tables.Count)));
 
     public override void AcceptVisitor(ISqlVisitor visitor)
     {
@@ -36,7 +34,7 @@ internal SqlForceJoinOrderHint()
 
     internal SqlForceJoinOrderHint(SqlTable[] tables)
     {
-      this.tables = tables;
+      Tables = tables;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public static LocalizationConfiguration Load(IConfiguration configuration, strin`
`146`	`146`	`return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);`
`147`	`147`	`}`
`148`	`148`	`else if (configuration is IConfigurationSection configurationSection) {`
`149`		`- return sectionName.IsNullOrEmpty()`
	`149`	`+ return string.IsNullOrEmpty(sectionName)`
`150`	`150`	`? new LocalizationConfigurationReader().Read(configurationSection)`
`151`	`151`	`: new LocalizationConfigurationReader().Read(configurationSection.GetSection(sectionName));`
`152`	`152`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	`}`
`55`		`- if(!cultureName.IsNullOrEmpty()) {`
	`55`	`+ if(!string.IsNullOrEmpty(cultureName)) {`
`56`	`56`	`try {`
`57`	`57`	`defaultCulture = CultureInfo.GetCultureInfo(cultureName);`
`58`	`58`	`}`
`@@ -64,4 +64,4 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati`
`64`	`64`	`return new LocalizationConfiguration() { DefaultCulture = defaultCulture };`
`65`	`65`	`}`
`66`	`66`	`}`
`67`		`-}`
	`67`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -68,11 +68,11 @@ protected override SecurityConfiguration ReadInternal(IConfigurationSection conf`
`68`	`68`	`}`
`69`	`69`	`if ((hashingServiceName ?? authenticationServiceName) != null) {`
`70`	`70`	`var securityConfiguration = new SecurityConfiguration(true);`
`71`		`- if (!hashingServiceName.IsNullOrEmpty()) {`
	`71`	`+ if (!string.IsNullOrEmpty(hashingServiceName)) {`
`72`	`72`	`securityConfiguration.HashingServiceName = hashingServiceName.ToLowerInvariant();`
`73`	`73`	`}`
`74`	`74`
`75`		`- if (!authenticationServiceName.IsNullOrEmpty()) {`
	`75`	`+ if (!string.IsNullOrEmpty(authenticationServiceName)) {`
`76`	`76`	`securityConfiguration.AuthenticationServiceName = authenticationServiceName.ToLowerInvariant();`
`77`	`77`	`}`
`78`	`78`
Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ public override void Visit(SqlFastFirstRowsHint node) =>`
`292`	`292`
`293`	`293`	`public override void Visit(SqlForceJoinOrderHint node)`
`294`	`294`	`{`
`295`		`- if (node.Tables.IsNullOrEmpty()) {`
	`295`	`+ if (!(node.Tables?.Count > 0)) {`
`296`	`296`	`_ = context.Output.Append("ORDERED");`
`297`	`297`	`}`
`298`	`298`	`else {`
`@@ -583,4 +583,4 @@ protected internal Compiler(SqlDriver driver)`
`583`	`583`	`{`
`584`	`584`	`}`
`585`	`585`	`}`
`586`		`-}`
	`586`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1133,7 +1133,7 @@ public void AllByFieldOfPoco01Test()`
`1133`	`1133`	`using (var transaction = session.OpenTransaction()) {`
`1134`	`1134`	`_ = session.Query.All<TestEntity>()`
`1135`	`1135`	`.Select(e => new Poco { Name = e.Name })`
`1136`		`- .All(el => el.Name.IsNullOrEmpty());`
	`1136`	`+ .All(el => string.IsNullOrEmpty(el.Name));`
`1137`	`1137`	`}`
`1138`	`1138`	`}`
`1139`	`1139`
`@@ -1144,7 +1144,7 @@ public void AllByFieldOfPoco02Test()`
`1144`	`1144`	`using (var transaction = session.OpenTransaction()) {`
`1145`	`1145`	`_ = session.Query.All<TestEntity>()`
`1146`	`1146`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1147`		`- .All(el => el.Name.IsNullOrEmpty());`
	`1147`	`+ .All(el => string.IsNullOrEmpty(el.Name));`
`1148`	`1148`	`}`
`1149`	`1149`	`}`
`1150`	`1150`
`@@ -1155,7 +1155,7 @@ public void AllByFieldOfPoco03Test()`
`1155`	`1155`	`using (var transaction = session.OpenTransaction()) {`
`1156`	`1156`	`_ = session.Query.All<TestEntity>()`
`1157`	`1157`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1158`		`- .All(el => el.Name.IsNullOrEmpty());`
	`1158`	`+ .All(el => string.IsNullOrEmpty(el.Name));`
`1159`	`1159`	`}`
`1160`	`1160`	`}`
`1161`	`1161`
`@@ -1166,7 +1166,7 @@ public void AllByFieldOfPoco04Test()`
`1166`	`1166`	`using (var transaction = session.OpenTransaction()) {`
`1167`	`1167`	`_ = Assert.Throws<QueryTranslationException>(() => session.Query.All<TestEntity>()`
`1168`	`1168`	`.Select(e => new Poco { BaseName = e.Name })`
`1169`		`- .All(el => el.Name.IsNullOrEmpty()));`
	`1169`	`+ .All(el => string.IsNullOrEmpty(el.Name)));`
`1170`	`1170`	`}`
`1171`	`1171`	`}`
`1172`	`1172`
`@@ -1177,7 +1177,7 @@ public void AllByFieldOfPoco05Test()`
`1177`	`1177`	`using (var transaction = session.OpenTransaction()) {`
`1178`	`1178`	`_ = session.Query.All<TestEntity>()`
`1179`	`1179`	`.Select(e => new Poco())`
`1180`		`- .All(el => el.Name.IsNullOrEmpty());`
	`1180`	`+ .All(el => string.IsNullOrEmpty(el.Name));`
`1181`	`1181`	`}`
`1182`	`1182`	`}`
`1183`	`1183`
`@@ -1189,7 +1189,7 @@ public void AnyByFieldOfPoco01Test()`
`1189`	`1189`	`using (var transaction = session.OpenTransaction()) {`
`1190`	`1190`	`_ = session.Query.All<TestEntity>()`
`1191`	`1191`	`.Select(e => new Poco { Name = e.Name })`
`1192`		`- .Any(el => el.Name.IsNullOrEmpty());`
	`1192`	`+ .Any(el => string.IsNullOrEmpty(el.Name));`
`1193`	`1193`	`}`
`1194`	`1194`	`}`
`1195`	`1195`
`@@ -1200,7 +1200,7 @@ public void AnyByFieldOfPoco02Test()`
`1200`	`1200`	`using (var transaction = session.OpenTransaction()) {`
`1201`	`1201`	`_ = session.Query.All<TestEntity>()`
`1202`	`1202`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1203`		`- .Any(el => el.Name.IsNullOrEmpty());`
	`1203`	`+ .Any(el => string.IsNullOrEmpty(el.Name));`
`1204`	`1204`	`}`
`1205`	`1205`	`}`
`1206`	`1206`
`@@ -1211,7 +1211,7 @@ public void AnyByFieldOfPoco03Test()`
`1211`	`1211`	`using (var transaction = session.OpenTransaction()) {`
`1212`	`1212`	`_ = session.Query.All<TestEntity>()`
`1213`	`1213`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1214`		`- .Any(el => el.BaseName.IsNullOrEmpty());`
	`1214`	`+ .Any(el => string.IsNullOrEmpty(el.BaseName));`
`1215`	`1215`	`}`
`1216`	`1216`	`}`
`1217`	`1217`
`@@ -1222,7 +1222,7 @@ public void AnyByFieldOfPoco04Test()`
`1222`	`1222`	`using (var transaction = session.OpenTransaction()) {`
`1223`	`1223`	`_ = session.Query.All<TestEntity>()`
`1224`	`1224`	`.Select(e => new Poco { BaseName = e.Name })`
`1225`		`- .Any(el => el.BaseName.IsNullOrEmpty());`
	`1225`	`+ .Any(el => string.IsNullOrEmpty(el.BaseName));`
`1226`	`1226`	`}`
`1227`	`1227`	`}`
`1228`	`1228`
`@@ -1233,7 +1233,7 @@ public void AnyByFieldOfPoco05Test()`
`1233`	`1233`	`using (var transaction = session.OpenTransaction()) {`
`1234`	`1234`	`_ = session.Query.All<TestEntity>()`
`1235`	`1235`	`.Select(e => new Poco())`
`1236`		`- .Any(el => el.Name.IsNullOrEmpty());`
	`1236`	`+ .Any(el => string.IsNullOrEmpty(el.Name));`
`1237`	`1237`	`}`
`1238`	`1238`	`}`
`1239`	`1239`
`@@ -1347,7 +1347,7 @@ public void CountByFieldOfPoco01Test()`
`1347`	`1347`	`using (var transaction = session.OpenTransaction()) {`
`1348`	`1348`	`_ = session.Query.All<TestEntity>()`
`1349`	`1349`	`.Select(e => new Poco { Name = e.Name })`
`1350`		`- .Count(el => el.Name.IsNullOrEmpty());`
	`1350`	`+ .Count(el => string.IsNullOrEmpty(el.Name));`
`1351`	`1351`	`}`
`1352`	`1352`	`}`
`1353`	`1353`
`@@ -1358,7 +1358,7 @@ public void CountByFieldOfPoco02Test()`
`1358`	`1358`	`using (var transaction = session.OpenTransaction()) {`
`1359`	`1359`	`_ = session.Query.All<TestEntity>()`
`1360`	`1360`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1361`		`- .Count(el => el.Name.IsNullOrEmpty());`
	`1361`	`+ .Count(el => string.IsNullOrEmpty(el.Name));`
`1362`	`1362`	`}`
`1363`	`1363`	`}`
`1364`	`1364`
`@@ -1369,7 +1369,7 @@ public void CountByFieldOfPoco03Test()`
`1369`	`1369`	`using (var transaction = session.OpenTransaction()) {`
`1370`	`1370`	`_ = session.Query.All<TestEntity>()`
`1371`	`1371`	`.Select(e => new Poco { Name = e.Name, BaseName = e.Name })`
`1372`		`- .Count(el => el.BaseName.IsNullOrEmpty());`
	`1372`	`+ .Count(el => string.IsNullOrEmpty(el.BaseName));`
`1373`	`1373`	`}`
`1374`	`1374`	`}`
`1375`	`1375`
`@@ -1380,7 +1380,7 @@ public void CountByFieldOfPoco04Test()`
`1380`	`1380`	`using (var transaction = session.OpenTransaction()) {`
`1381`	`1381`	`_ = session.Query.All<TestEntity>()`
`1382`	`1382`	`.Select(e => new Poco { BaseName = e.Name })`
`1383`		`- .Count(el => el.BaseName.IsNullOrEmpty());`
	`1383`	`+ .Count(el => string.IsNullOrEmpty(el.BaseName));`
`1384`	`1384`	`}`
`1385`	`1385`	`}`
`1386`	`1386`
`@@ -1391,7 +1391,7 @@ public void CountByFieldOfPoco05Test()`
`1391`	`1391`	`using (var transaction = session.OpenTransaction()) {`
`1392`	`1392`	`_ = session.Query.All<TestEntity>()`
`1393`	`1393`	`.Select(e => new Poco())`
`1394`		`- .Count(el => el.Name.IsNullOrEmpty());`
	`1394`	`+ .Count(el => string.IsNullOrEmpty(el.Name));`
`1395`	`1395`	`}`
`1396`	`1396`	`}`
`1397`	`1397`
Original file line number	Diff line number	Diff line change
`@@ -12,16 +12,14 @@ namespace Xtensive.Sql.Dml`
`12`	`12`	`[Serializable]`
`13`	`13`	`public class SqlForceJoinOrderHint : SqlHint`
`14`	`14`	`{`
`15`		`- private SqlTable[] tables;`
`16`		`-`
`17`	`15`	`/// <summary>`
`18`	`16`	`/// Gets the corresponding tables.`
`19`	`17`	`/// </summary>`
`20`		`- public IEnumerable<SqlTable> Tables { get { return tables; } }`
	`18`	`+ public IReadOnlyList<SqlTable> Tables { get; }`
`21`	`19`
`22`	`20`	`internal override SqlForceJoinOrderHint Clone(SqlNodeCloneContext? context = null) =>`
`23`	`21`	`context.GetOrAdd(this, static (t, c) =>`
`24`		`- new(t.tables?.Select(table => table.Clone()).ToArray(t.tables.Length)));`
	`22`	`+ new(t.Tables?.Select(table => table.Clone()).ToArray(t.Tables.Count)));`
`25`	`23`
`26`	`24`	`public override void AcceptVisitor(ISqlVisitor visitor)`
`27`	`25`	`{`
`@@ -36,7 +34,7 @@ internal SqlForceJoinOrderHint()`
`36`	`34`
`37`	`35`	`internal SqlForceJoinOrderHint(SqlTable[] tables)`
`38`	`36`	`{`
`39`		`- this.tables = tables;`
	`37`	`+ Tables = tables;`
`40`	`38`	`}`
`41`	`39`	`}`
`42`	`40`	`}`