Optimize DataTable.Columns - avoid unnecessary type casting (#320)

* Optimize `DataTable.Columns` - avoid unnecessary type casting

* Constrants

* Upgrade SQL Server

* Explicit path to sqlcmd

* Install MSSQL tools

* Revert sqlcmd path

Author: SergeiPavlov

.github/actions/mssql-fts/Dockerfile

@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/mssql/server:2022-CU14-ubuntu-22.04
+FROM mcr.microsoft.com/mssql/server:2022-CU16-ubuntu-22.04
 USER root
 
 ENV ACCEPT_EULA=Y \

.github/workflows/test-sql.yaml

@@ -20,6 +20,11 @@ jobs:
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with: { dotnet-version: 8 }
+      - name: Setup MSSQL Tools
+        uses:  rails-sqlserver/setup-mssql@v1
+        with:
+          components: sqlcmd
+          version: 2022
       - name: Build SQL Docker image with FTS feature
         run: docker build -t sql .github/actions/mssql-fts
 #      - uses: ikalnytskyi/action-setup-postgres@v6 

Orm/Xtensive.Orm/Core/Extensions/ArrayExtensions.cs

@@ -36,24 +36,6 @@ public static TNewItem[] Cast<TItem, TNewItem>(this TItem[] source)
       return items;
     }
 
-    /// <summary>
-    /// Clones <paramref name="source"/> array with element conversion.
-    /// </summary>
-    /// <typeparam name="TItem">The type of item.</typeparam>
-    /// <typeparam name="TNewItem">The type of item to convert to.</typeparam>
-    /// <param name="source">The array to convert.</param>
-    /// <param name="converter">A delegate that converts each element.</param>
-    /// <returns>An array of converted elements.</returns>
-    public static TNewItem[] Convert<TItem, TNewItem>(this TItem[] source, Converter<TItem, TNewItem> converter)
-    {
-      ArgumentNullException.ThrowIfNull(converter);
-      var items = new TNewItem[source.Length];
-      int i = 0;
-      foreach (TItem item in source)
-        items[i++] = converter(item);
-      return items;
-    }
-
     /// <summary>
     /// Gets the index of first occurrence of the <paramref name="item"/>
     /// in the <paramref name="items"/> array, if found;

Orm/Xtensive.Orm/Sql/Model/DataTable.cs

@@ -57,7 +57,7 @@ public PairedNodeCollection<DataTable, Index> Indexes
     /// Gets the columns.
     /// </summary>
     /// <value>The columns.</value>
-    public abstract IList<DataTableColumn> Columns { get; }
+    public abstract IReadOnlyList<DataTableColumn> Columns { get; }
 
     #endregion
 

Orm/Xtensive.Orm/Sql/Model/Domain.cs

@@ -90,13 +90,7 @@ public PairedNodeCollection<Domain, DomainConstraint> DomainConstraints
     /// Gets the constraints.
     /// </summary>
     /// <value>The constraints.</value>
-    IList<Constraint> IConstrainable.Constraints
-    {
-      get
-      {
-        return constraints.ToArray().Convert(i => (Constraint)i);
-      }
-    }
+    IReadOnlyList<Constraint> IConstrainable.Constraints => constraints;
 
     #endregion
 
@@ -142,4 +136,4 @@ internal Domain(Schema schema, string name, SqlValueType dataType, SqlExpression
 
     #endregion
   }
-}
+}

Orm/Xtensive.Orm/Sql/Model/Interfaces/IConstrainable.cs

@@ -15,6 +15,6 @@ public interface IConstrainable
     /// Gets the node constraints.
     /// </summary>
     /// <value>The constraints.</value>
-    IList<Constraint> Constraints { get; }
+    IReadOnlyList<Constraint> Constraints { get; }
   }
 }

Orm/Xtensive.Orm/Sql/Model/Table.cs

@@ -148,10 +148,7 @@ public string Filegroup
     /// Gets the columns.
     /// </summary>
     /// <value>The columns.</value>
-    public override IList<DataTableColumn> Columns
-    {
-      get { return TableColumns.ToArray().Convert(i => (DataTableColumn) i); }
-    }
+    public override IReadOnlyList<DataTableColumn> Columns => TableColumns;
 
     #endregion
 
@@ -161,10 +158,7 @@ public override IList<DataTableColumn> Columns
     /// Gets the node constraints.
     /// </summary>
     /// <value>The constraints.</value>
-    IList<Constraint> IConstrainable.Constraints
-    {
-      get { return constraints.ToArray().Convert(i => (Constraint)i); }
-    }
+    IReadOnlyList<Constraint> IConstrainable.Constraints => constraints;
 
     #endregion
 
@@ -214,4 +208,4 @@ internal Table(Schema schema, string name)
 
     #endregion
   }
-}
+}

Orm/Xtensive.Orm/Sql/Model/View.cs

@@ -89,11 +89,7 @@ protected override void ChangeSchema(Schema value)
     /// Gets the columns.
     /// </summary>
     /// <value>The columns.</value>
-    public override IList<DataTableColumn> Columns {
-      get {
-        return ViewColumns.ToArray().Convert(i => (DataTableColumn) i);
-      }
-    }
+    public override IReadOnlyList<DataTableColumn> Columns => ViewColumns;
 
     #endregion
 
@@ -134,4 +130,4 @@ internal View(Schema schema, string name, SqlNative definition, CheckOptions che
 
     #endregion
   }
-}
+}