From 0e36ca4000ca6a555c1531742a9c583482d1afac Mon Sep 17 00:00:00 2001
From: Sergei Pavlov <spavlov@servicetitan.com>
Date: Fri, 8 Aug 2025 20:10:40 -0700
Subject: [PATCH] Optimize `QueryableExtensions`: preallocate immutable
 `Expression.Parameter`

---
 Orm/Xtensive.Orm/Orm/QueryableExtensions.Async.cs | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Orm/Xtensive.Orm/Orm/QueryableExtensions.Async.cs b/Orm/Xtensive.Orm/Orm/QueryableExtensions.Async.cs
index ecbba9b1b..6bdb78554 100644
--- a/Orm/Xtensive.Orm/Orm/QueryableExtensions.Async.cs
+++ b/Orm/Xtensive.Orm/Orm/QueryableExtensions.Async.cs
@@ -16,6 +16,11 @@ namespace Xtensive.Orm
   /// </summary>
   public static partial class QueryableExtensions
   {
+    private static class ParameterTraits<TSource>
+    {
+      public static readonly ParameterExpression[] ItemParam = [Expression.Parameter(typeof(TSource), "item")];
+    }
+
     private static readonly object BoxedZero = 0;
 
     /// <summary>
@@ -1399,7 +1404,7 @@ public static async Task<Dictionary<TKey, TSource>> ToDictionaryAsync<TKey, TSou
       Expression<Func<TSource, TKey>> keySelector, CancellationToken cancellationToken = default)
     {
       var tupleFactoryMethod = TupleCreateMethod.CachedMakeGenericMethod(typeof(TKey), typeof(TSource));
-      var itemParam = new[] {Expression.Parameter(typeof(TSource), "item")};
+      var itemParam = ParameterTraits<TSource>.ItemParam;
       var body = Expression.Call(null, tupleFactoryMethod,
         ExpressionReplacer.ReplaceAll(keySelector.Body, keySelector.Parameters, itemParam),
         itemParam[0]);
@@ -1441,7 +1446,7 @@ public static async Task<Dictionary<TKey, TValue>> ToDictionaryAsync<TKey, TValu
       CancellationToken cancellationToken = default)
     {
       var tupleFactoryMethod = TupleCreateMethod.CachedMakeGenericMethod(typeof(TKey), typeof(TValue));
-      var itemParam = new[] {Expression.Parameter(typeof(TSource), "item")};
+      var itemParam = ParameterTraits<TSource>.ItemParam;
       var body = Expression.Call(null, tupleFactoryMethod,
         ExpressionReplacer.ReplaceAll(keySelector.Body, keySelector.Parameters, itemParam),
         ExpressionReplacer.ReplaceAll(valueSelector.Body, valueSelector.Parameters, itemParam));
@@ -1506,7 +1511,7 @@ public static async Task<ILookup<TKey, TSource>> ToLookupAsync<TKey, TSource>(th
       Expression<Func<TSource, TKey>> keySelector, CancellationToken cancellationToken = default)
     {
       var tupleFactoryMethod = TupleCreateMethod.CachedMakeGenericMethod(typeof(TKey), typeof(TSource));
-      var itemParam = new[] {Expression.Parameter(typeof(TSource), "item")};
+      var itemParam = ParameterTraits<TSource>.ItemParam;
       var body = Expression.Call(null, tupleFactoryMethod,
         ExpressionReplacer.ReplaceAll(keySelector.Body, keySelector.Parameters, itemParam),
         itemParam[0]);
@@ -1543,7 +1548,7 @@ public static async Task<ILookup<TKey, TValue>> ToLookupAsync<TKey, TValue, TSou
       CancellationToken cancellationToken = default)
     {
       var tupleFactoryMethod = TupleCreateMethod.CachedMakeGenericMethod(typeof(TKey), typeof(TValue));
-      var itemParam = new[] {Expression.Parameter(typeof(TSource), "item")};
+      var itemParam = ParameterTraits<TSource>.ItemParam;
       var body = Expression.Call(null, tupleFactoryMethod,
         ExpressionReplacer.ReplaceAll(keySelector.Body, keySelector.Parameters, itemParam),
         ExpressionReplacer.ReplaceAll(valueSelector.Body, valueSelector.Parameters, itemParam));