Disabled MTU discovery & C API tweaks

• Updated some C types from `const char**` to `const char* const*` to fix up the Swift interface
• Updated to the latest libQuic and disabled MTU discovery (caused issues with some networks)

Author: mpretty-cyro

external/oxen-libquic

@@ -95,8 +95,8 @@ typedef struct config_string_list {
 
 LIBSESSION_EXPORT config_string_list* config_merge(
         config_object* conf,
-        const char** msg_hashes,
-        const unsigned char** configs,
+        const char* const* msg_hashes,
+        const unsigned char* const* configs,
         const size_t* lengths,
         size_t count) LIBSESSION_WARN_UNUSED;
 

include/session/config/base.h

@@ -333,7 +333,7 @@ LIBSESSION_EXPORT void groups_keys_dump(
 ///   them on failure.
 LIBSESSION_EXPORT bool groups_keys_key_supplement(
         config_group_keys* conf,
-        const char** sids,
+        const char* const* sids,
         size_t sids_len,
         unsigned char** message,
         size_t* message_len);

include/session/config/groups/keys.h

@@ -53,10 +53,10 @@ extern "C" {
 /// responsibility to `free()` this buffer (if non-NULL) when done with it!
 LIBSESSION_EXPORT unsigned char* session_encrypt_for_multiple_simple(
         size_t* out_len,
-        const unsigned char** messages,
+        const unsigned char* const* messages,
         const size_t* message_lengths,
         size_t n_messages,
-        const unsigned char** recipients,
+        const unsigned char* const* recipients,
         size_t n_recipients,
         const unsigned char* x25519_privkey,
         const unsigned char* x25519_pubkey,
@@ -69,10 +69,10 @@ LIBSESSION_EXPORT unsigned char* session_encrypt_for_multiple_simple(
 /// from the Ed25519 key on the fly.
 LIBSESSION_EXPORT unsigned char* session_encrypt_for_multiple_simple_ed25519(
         size_t* out_len,
-        const unsigned char** messages,
+        const unsigned char* const* messages,
         const size_t* message_lengths,
         size_t n_messages,
-        const unsigned char** recipients,
+        const unsigned char* const* recipients,
         size_t n_recipients,
         const unsigned char* ed25519_secret_key,
         const char* domain,

include/session/multi_encrypt.h

@@ -37,8 +37,8 @@ typedef struct network_server_destination {
     const char* endpoint;
     uint16_t port;
     const char* x25519_pubkey;
-    const char** headers;
-    const char** header_values;
+    const char* const* headers;
+    const char* const* header_values;
     size_t headers_size;
 } network_server_destination;
 
@@ -197,8 +197,8 @@ typedef void (*network_onion_response_callback_t)(
         bool success,
         bool timeout,
         int16_t status_code,
-        const char** headers,
-        const char** header_values,
+        const char* const* headers,
+        const char* const* header_values,
         size_t headers_size,
         const char* response,
         size_t response_size,

include/session/network.h

@@ -764,8 +764,8 @@ LIBSESSION_EXPORT int16_t config_storage_namespace(const config_object* conf) {
 
 LIBSESSION_EXPORT config_string_list* config_merge(
         config_object* conf,
-        const char** msg_hashes,
-        const unsigned char** configs,
+        const char* const* msg_hashes,
+        const unsigned char* const* configs,
         const size_t* lengths,
         size_t count) {
     return wrap_exceptions(conf, [&] {

src/config/base.cpp

@@ -1659,7 +1659,7 @@ LIBSESSION_C_API bool groups_keys_decrypt_message(
 
 LIBSESSION_C_API bool groups_keys_key_supplement(
         config_group_keys* conf,
-        const char** sids,
+        const char* const* sids,
         size_t sids_len,
         unsigned char** message,
         size_t* message_len) {

src/config/groups/keys.cpp

@@ -259,10 +259,10 @@ static unsigned char* to_c_buffer(std::span<const unsigned char> x, size_t* out_
 
 LIBSESSION_C_API unsigned char* session_encrypt_for_multiple_simple(
         size_t* out_len,
-        const unsigned char** messages,
+        const unsigned char* const* messages,
         const size_t* message_lengths,
         size_t n_messages,
-        const unsigned char** recipients,
+        const unsigned char* const* recipients,
         size_t n_recipients,
         const unsigned char* x25519_privkey,
         const unsigned char* x25519_pubkey,
@@ -298,10 +298,10 @@ LIBSESSION_C_API unsigned char* session_encrypt_for_multiple_simple(
 
 LIBSESSION_C_API unsigned char* session_encrypt_for_multiple_simple_ed25519(
         size_t* out_len,
-        const unsigned char** messages,
+        const unsigned char* const* messages,
         const size_t* message_lengths,
         size_t n_messages,
-        const unsigned char** recipients,
+        const unsigned char* const* recipients,
         size_t n_recipients,
         const unsigned char* ed25519_secret_key,
         const char* domain,

src/multi_encrypt.cpp

@@ -767,7 +767,7 @@ std::chrono::milliseconds Network::retry_delay(
 std::shared_ptr<quic::Endpoint> Network::get_endpoint() {
     return net.call_get([this]() mutable {
         if (!endpoint)
-            endpoint = net.endpoint(quic::Address{"0.0.0.0", 0}, quic::opt::alpns{ALPN});
+            endpoint = net.endpoint(quic::Address{"0.0.0.0", 0}, quic::opt::alpns{ALPN}, quic::opt::disable_mtu_discovery{});
 
         return endpoint;
     });

src/network.cpp

@@ -1281,8 +1281,8 @@ TEST_CASE("Network direct request C API", "[network][network_send_request]") {
             [](bool success,
                bool timeout,
                int16_t status_code,
-               const char** headers,
-               const char** header_values,
+               const char* const* headers,
+               const char* const* header_values,
                size_t headers_size,
                const char* c_response,
                size_t response_size,