Skip to content

Commit c7b8537

Browse files
author
Chan Shing Fai
committed
Support for mysql SSL connection
1 parent 7610f31 commit c7b8537

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

README.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,6 @@ sqlToBq.exec(['users'], function(error) {
3030
});
3131
```
3232

33-
OR set following value instead of `mySqlConfig` and `bigQueryConfig`
34-
35-
```
36-
export RDS_HOST=xxxxxxxx
37-
export RDS_USER=xxxxxxxx
38-
export RDS_PASSWORD=xxxxxxxx
39-
export RDS_DATABASE=xxxxxxxx
40-
export BQ_PROJECT_ID=xxxxxxxx
41-
export BQ_KEY_FILENAME=xxxxxxxx
42-
export BQ_DATASET=xxxxxxxx
43-
```
44-
4533
## Tests
4634
ToDo
4735

src/RDBtoBigQuery.js

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,12 @@ export default class MySQLtoBigQuery {
1414
const bigQueryConfig = config.bigQueryConfig || {};
1515

1616
// init MySQL
17-
this.connection = mysql.createConnection({
18-
host: mySqlConfig.host || process.env.RDS_HOST,
19-
user: mySqlConfig.user || process.env.RDS_USER,
20-
password: mySqlConfig.password || process.env.RDS_PASSWORD,
21-
database: mySqlConfig.database || process.env.RDS_DATABASE
22-
});
17+
this.connection = mysql.createConnection(mySqlConfig);
2318

2419
this.connection.connect();
2520

2621
// init BigQuery
27-
this.bq = bigquery({
28-
projectId: bigQueryConfig.projectId || process.env.BQ_PROJECT_ID,
29-
keyFilename: bigQueryConfig.keyFilename || process.env.BQ_KEY_FILENAME
30-
});
22+
this.bq = bigquery(bigQueryConfig);
3123

3224
this.dataset = this.bq.dataset(bigQueryConfig.dataset || process.env.BQ_DATASET);
3325
}

0 commit comments

Comments
 (0)