Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code typos: extra .value in calling evm.stack.pop() #22

Open
0x6980 opened this issue Aug 17, 2024 · 0 comments
Open

Code typos: extra .value in calling evm.stack.pop() #22

0x6980 opened this issue Aug 17, 2024 · 0 comments

Comments

@0x6980
Copy link

0x6980 commented Aug 17, 2024

In function sload(evm) of content/07a_opcodes/10_storage.ipynb

def sload(evm): 
    key = evm.stack.pop().value
    warm, value = evm.storage.load(key)
    evm.stack.push(value)

    evm.gas_dec(2100) # 100 if warm
    evm.pc += 1

key = evm.stack.pop().value should be key = evm.stack.pop()

same problem in content/07a_opcodes/17_transient file in tload function.

@0x6980 0x6980 changed the title Code typos on content/07a_opcodes/10_storage.ipynb Code typos: extra .value in calling evm.stack.pop() Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant