Skip to content

Repeating deserialisation twice per object #80

Open
@dr86ansixavier

Description

@dr86ansixavier

Hi Team,

Please look at the below code segment from index.ts file. It's doing deserialisation twice per object because we are assigning the first element for deserialisation first and then the popped element again.

`const runDeserialization = (conversionFunctionStructures: ConversionFunctionStructure[]): void => {

    const converstionFunctionsArray: Array<ConversionFunctionStructure> = [];
    conversionFunctionStructures.forEach((struct: ConversionFunctionStructure) => {
        converstionFunctionsArray.push(struct);
    });

    **let conversionFunctionStructure: ConversionFunctionStructure = converstionFunctionsArray[0];** //This line needs to be replaced with **let conversionFunctionStructure: ConversionFunctionStructure = (converstionFunctionsArray.length > 0)? converstionFunctionsArray.pop() : undefined;**

    // tslint:disable-next-line:triple-equals
    while (conversionFunctionStructure != undefined) {
        const stackEntries: Array<ConversionFunctionStructure> = conversionFunctions[conversionFunctionStructure.functionName](
            conversionFunctionStructure.instance, conversionFunctionStructure.instanceKey,
            conversionFunctionStructure.type, conversionFunctionStructure.json,
            conversionFunctionStructure.jsonKey);
        stackEntries.forEach((structure: ConversionFunctionStructure) => {
            converstionFunctionsArray.push(structure);
        });
        conversionFunctionStructure = converstionFunctionsArray.pop();
    }
};`

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions