Skip to content

Commit 63efb38

Browse files
authored
chore: drops PII filter temporary. (hypertrace#44)
1 parent 2431c9c commit 63efb38

28 files changed

+0
-9286
lines changed

_tests/e2e/test-config.yml

-11
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
receivers:
22
zipkin:
33

4-
processors:
5-
hypertrace_piifilter:
6-
redaction_strategy: redact
7-
key_regexs:
8-
- regex: "card.last_4"
9-
- regex: "^password$"
10-
complex_data:
11-
- key: http.request.body
12-
type: json
134
exporters:
145
file:
156
path: ./exported-trace.json
@@ -19,7 +10,5 @@ service:
1910
traces:
2011
receivers:
2112
- zipkin
22-
processors:
23-
- hypertrace_piifilter
2413
exporters:
2514
- file

_tests/e2e/test.sh

-22
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,3 @@ else
2323
echo "Unexpected trace ID \"$TRACE_ID\"."
2424
exit 1
2525
fi
26-
27-
# Assertions declared here should be also declared in the test-config.yml
28-
29-
# Key base redaction
30-
CARD_LAST_4=$(tail -n 1 $EXPORTED_TRACE | jq -r '.resourceSpans[].instrumentationLibrarySpans[].spans[].attributes[] | select (.key | contains("card.last_4")) | .value.stringValue')
31-
32-
if [ "$CARD_LAST_4" == "***" ]; then
33-
echo "Attribute card.last_4 has been redacted correctly."
34-
else
35-
echo "Attribute card.last_4 hasn't been redacted correctly: \"$CARD_LAST_4\"."
36-
exit 1
37-
fi
38-
39-
# JSON payload key based redaction
40-
JSON_PASSWORD=$(tail -n 1 $EXPORTED_TRACE | jq -r '.resourceSpans[].instrumentationLibrarySpans[].spans[].attributes[] | select (.key | contains("http.request.body")) | .value.stringValue | select (. | contains("password"))' | jq -r '.password')
41-
42-
if [ "$JSON_PASSWORD" == "***" ]; then
43-
echo "Attribute http.request.body has been redacted correctly."
44-
else
45-
echo "Attribute http.request.body hasn't been redacted correctly, password field: \"$JSON_PASSWORD\"."
46-
exit 1
47-
fi

cmd/collector/main.go

-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"go.opentelemetry.io/collector/service"
1111
"go.opentelemetry.io/collector/service/defaultcomponents"
1212

13-
"github.com/hypertrace/collector/processors/piifilterprocessor"
1413
"github.com/hypertrace/collector/processors/tenantidprocessor"
1514
)
1615

@@ -44,7 +43,6 @@ func components() (component.Factories, error) {
4443
}
4544

4645
processors := []component.ProcessorFactory{
47-
piifilterprocessor.NewFactory(),
4846
tenantidprocessor.NewFactory(),
4947
}
5048
for _, pr := range factories.Processors {

processors/parsed_attribte.go

-71
This file was deleted.

processors/parsed_attribute_test.go

-36
This file was deleted.

processors/piifilterprocessor/config.go

-147
This file was deleted.

processors/piifilterprocessor/config_test.go

-51
This file was deleted.

0 commit comments

Comments
 (0)