Port: Make port available only when reported as active

Ports reports their statuses via a status field, we should take that
into consideration when computing if the port is available or not.

With this change, ports are reported as Available when the object has
a known ID for the resource, and the resource has ACTIVE status.

Fixes k-orc#198

Author: mandre

internal/controllers/port/status.go

@@ -24,6 +24,10 @@ import (
 	orcapplyconfigv1alpha1 "github.com/k-orc/openstack-resource-controller/pkg/clients/applyconfiguration/api/v1alpha1"
 )
 
+const (
+	PortStatusActive = "ACTIVE"
+)
+
 type objectApplyPT = *orcapplyconfigv1alpha1.PortApplyConfiguration
 type statusApplyPT = *orcapplyconfigv1alpha1.PortStatusApplyConfiguration
 
@@ -35,9 +39,8 @@ func (portStatusWriter) GetApplyConfigConstructor() generic.ORCApplyConfigConstr
 	return orcapplyconfigv1alpha1.Port
 }
 
-func (portStatusWriter) ResourceIsAvailable(_ orcObjectPT, osResource *osResourceT) bool {
-	// A port is available as soon as it exists
-	return osResource != nil
+func (portStatusWriter) ResourceIsAvailable(orcObject orcObjectPT, osResource *osResourceT) bool {
+	return orcObject.Status.ID != nil && osResource != nil && osResource.Status == PortStatusActive
 }
 
 func (portStatusWriter) ApplyResourceStatus(log logr.Logger, osResource *osResourceT, statusApply statusApplyPT) {