Skip to content

Commit 33ec971

Browse files
committed
Update spotbugs
1 parent faca320 commit 33ec971

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

findbugs-exclude.xml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,6 @@
1818
-->
1919

2020
<FindBugsFilter>
21-
<Match>
22-
<Class name="io.siddhi.extension.io.kafka.source.KafkaSource"/>
23-
<Bug pattern="IMPROPER_UNICODE"/>
24-
</Match>
25-
<Match>
26-
<Class name="io.siddhi.extension.io.kafka.source.KafkaReplayResponseSource"/>
27-
<Bug pattern="IMPROPER_UNICODE"/>
28-
</Match>
29-
<Match>
30-
<Class name="io.siddhi.extension.io.kafka.source.KafkaConsumerThread"/>
31-
<Bug pattern="IMPROPER_UNICODE"/>
32-
</Match>
33-
<Match>
34-
<Class name="io.siddhi.extension.io.kafka.sink.KafkaSink"/>
35-
<Bug pattern="IMPROPER_UNICODE"/>
36-
</Match>
3721
<Match>
3822
<Class name="io.siddhi.extension.io.kafka.multidc.source.SourceSynchronizer"/>
3923
<Bug pattern="DLS_DEAD_LOCAL_STORE"/>
@@ -42,4 +26,8 @@
4226
<Package name="~io\.siddhi\.extension\.io\.kafka.*"/>
4327
<Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
4428
</Match>
29+
<Match>
30+
<Class name="io.siddhi.extension.io.kafka.source.KafkaSource"/>
31+
<Bug pattern="RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE"/>
32+
</Match>
4533
</FindBugsFilter>

pom.xml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,12 +332,26 @@
332332
<autoVersionSubmodules>true</autoVersionSubmodules>
333333
</configuration>
334334
</plugin>
335-
<plugin>
335+
<plugin><!-- Overridden from parent pom to exclude generated sources -->
336336
<groupId>com.github.spotbugs</groupId>
337337
<artifactId>spotbugs-maven-plugin</artifactId>
338-
<configuration>
338+
<configuration combine.self="override">
339+
<effort>Max</effort>
340+
<threshold>Low</threshold>
341+
<xmlOutput>true</xmlOutput>
342+
<spotbugsXmlOutputDirectory>${project.build.directory}/findbugs</spotbugsXmlOutputDirectory>
339343
<excludeFilterFile>${maven.findbugsplugin.version.exclude}</excludeFilterFile>
344+
<!--Exclude generated sources-->
340345
</configuration>
346+
<executions>
347+
<execution>
348+
<id>analyze-compile</id>
349+
<phase>compile</phase>
350+
<goals>
351+
<goal>check</goal>
352+
</goals>
353+
</execution>
354+
</executions>
341355
</plugin>
342356
</plugins>
343357

0 commit comments

Comments
 (0)