Fix profile selection and cmd-number scroll#22
Merged
Conversation
- CMD+1-8 now smooth-scrolls the selected model column into view - CMD+Shift+Space now moves the selected model to the first column position - Added data-compare-message-id attribute to compare block columns for scroll targeting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Analysis CompleteGenerated ECC bundle from 2 commits | Confidence: 50% View Pull Request #23Repository Profile
Changed Files (4)
Top hotspots
Top directories
Generated Instincts (14)
After merging, import with: Files
|
There was a problem hiding this comment.
Pull request overview
This PR improves MultiChat keyboard navigation and model selection persistence by ensuring model columns scroll into view on Cmd+number shortcuts, decoupling per-chat compare selection from the active model profile, and allowing an explicitly empty compare selection to be preserved instead of falling back to ambient defaults.
Changes:
- Auto-scroll the selected compare/tools model column into view when using Cmd+1–8.
- Rebind Cmd/Ctrl+Shift+Space to move the currently selected model to the first column position.
- Make per-chat compare selection independent of the active model profile and persist explicit empty selections.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ui/components/MultiChatDeprecationPath.tsx | Adds a data-compare-message-id hook to enable scroll-to-column behavior for compare columns. |
| src/ui/components/MultiChat.tsx | Implements scroll-into-view on Cmd+number for tools/compare and updates Cmd+Shift+Space to “pop to front”. |
| src/ui/components/ChatInput.tsx | Stops filtering compare-visible configs by active model profile; preserves empty saved compare selection when persisting. |
| src/core/chorus/api/ModelConfigChatAPI.ts | Updates compare selection resolution to treat “saved but empty” as authoritative (no ambient fallback) and removes active-profile filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
bug fixes for cmd+KEY and multi-model selection states |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing