refactor: prefer arrow functions

chintankavathia · spike-rabbit · commit f389894bd910 · 2025-07-02T19:22:43.000+02:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -52,8 +52,7 @@ export const tsConfig = typescriptEslint.config({
     '@angular-eslint/no-input-rename': ['off'],
     '@angular-eslint/no-output-native': ['off'],
     '@angular-eslint/directive-class-suffix': ['off'],
-    '@angular-eslint/no-conflicting-lifecycle': ['off'],
-    'prefer-arrow/prefer-arrow-functions': ['off']
+    '@angular-eslint/no-conflicting-lifecycle': ['off']
   }
 });
 
diff --git a/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.spec.ts
@@ -43,10 +43,10 @@ describe('DataTableSummaryRowComponent', () => {
     fixture.detectChanges();
   });
 
-  function triggerChange() {
+  const triggerChange = () => {
     component.ngOnChanges();
     fixture.detectChanges();
-  }
+  };
 
   describe('fixture', () => {
     it('should have a component instance', () => {
diff --git a/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts b/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.ts
@@ -3,7 +3,7 @@ import { Component, Input, OnChanges } from '@angular/core';
 import { TableColumnInternal } from '../../../types/internal.types';
 import { DataTableBodyRowComponent } from '../body-row.component';
 
-function defaultSumFunc(cells: any[]): any {
+const defaultSumFunc = (cells: any[]): any => {
   const cellsWithValues = cells.filter(cell => !!cell);
 
   if (!cellsWithValues.length) {
@@ -14,11 +14,11 @@ function defaultSumFunc(cells: any[]): any {
   }
 
   return cellsWithValues.reduce((res, cell) => res + cell);
-}
+};
 
-function noopSumFunc(cells: any[]): void {
+const noopSumFunc = (cells: any[]): void => {
   return;
-}
+};
 
 @Component({
   selector: 'datatable-summary-row',
diff --git a/projects/ngx-datatable/src/lib/components/datatable.component.spec.ts b/projects/ngx-datatable/src/lib/components/datatable.component.spec.ts
@@ -546,26 +546,26 @@ describe('DatatableComponent With Frozen columns', () => {
 /**
  * mimics the act of a user clicking a column to sort it
  */
-function sortBy({ column }: { column: number }, fixture: ComponentFixture<unknown>) {
+const sortBy = ({ column }: { column: number }, fixture: ComponentFixture<unknown>) => {
   const columnIndex = column - 1;
   const headerCellDe = fixture.debugElement.queryAll(By.css('datatable-header-cell'))[columnIndex];
   const de = headerCellDe.query(By.css('span:last-child'));
   de.triggerEventHandler('click', null);
-}
+};
 
 /**
  * test helper function to return text content of a cell within the
  * body of the ngx-datatable component
  */
-function textContent(
+const textContent = (
   { row, column }: { row: number; column: number },
   fixture: ComponentFixture<unknown>
-) {
+) => {
   const [rowIndex, columnIndex] = [row - 1, column - 1];
   const bodyRowDe = fixture.debugElement.queryAll(By.directive(DataTableBodyRowComponent))[
     rowIndex
   ];
   const bodyCellDe = bodyRowDe.queryAll(By.directive(DataTableBodyCellComponent))[columnIndex];
 
   return bodyCellDe.nativeElement.textContent;
-}
+};
diff --git a/projects/ngx-datatable/src/lib/components/footer/pager.component.spec.ts b/projects/ngx-datatable/src/lib/components/footer/pager.component.spec.ts
@@ -264,9 +264,9 @@ describe('DataTablePagerComponent', () => {
         .map((button, index) => ({ button, page: index + 1 }));
     });
 
-    function ariaLabel(element: DebugElement): string | null {
+    const ariaLabel = (element: DebugElement): string | null => {
       return element?.attributes['aria-label'] ?? null;
-    }
+    };
 
     describe('has default values without messages from table', () => {
       it('first button', () => {
@@ -293,11 +293,11 @@ describe('DataTablePagerComponent', () => {
     });
 
     describe('takes messages-overrides from table', () => {
-      function setMessages(messages: DatatableComponent['messages']) {
+      const setMessages = (messages: DatatableComponent['messages']) => {
         (pager as any).dataTable = { messages };
         // do a change detection on the real changeDetectionRef
         fixture.componentRef.injector.get(ChangeDetectorRef).detectChanges();
-      }
+      };
 
       it('first button', () => {
         setMessages({ ariaFirstPageMessage: 'link: first page' });
diff --git a/projects/ngx-datatable/src/lib/components/header/header.component.spec.ts b/projects/ngx-datatable/src/lib/components/header/header.component.spec.ts
@@ -81,7 +81,7 @@ describe('DataTableHeaderComponent', () => {
   });
 });
 
-function createColumn(id: string, resizeable = true): TableColumnInternal {
+const createColumn = (id: string, resizeable = true): TableColumnInternal => {
   return {
     $$id: id,
     prop: id,
@@ -93,4 +93,4 @@ function createColumn(id: string, resizeable = true): TableColumnInternal {
     maxWidth: 200,
     isTarget: false
   } as any;
-}
+};
diff --git a/projects/ngx-datatable/src/lib/directives/orderable.directive.spec.ts b/projects/ngx-datatable/src/lib/directives/orderable.directive.spec.ts
@@ -56,7 +56,7 @@ describe('OrderableDirective', () => {
     });
 
     describe('when a draggable is removed', () => {
-      function checkAllSubscriptionsForActiveObservers() {
+      const checkAllSubscriptionsForActiveObservers = () => {
         const subs = directive.draggables.map(d => {
           expect(d.dragEnd.isStopped).toBe(false);
           expect(d.dragStart.isStopped).toBe(false);
@@ -71,11 +71,11 @@ describe('OrderableDirective', () => {
           expect(sub.dragStart.length).toBe(1);
           expect(sub.dragEnd.length).toBe(1);
         });
-      }
+      };
 
-      function newDraggable(name: string): TableColumnInternal {
+      const newDraggable = (name: string): TableColumnInternal => {
         return toInternalColumn([{ name }])[0];
-      }
+      };
 
       beforeEach(() => {
         component.draggables = [newDraggable('d1'), newDraggable('d2'), newDraggable('d3')];
diff --git a/projects/ngx-datatable/src/lib/ngx-datatable.config.ts b/projects/ngx-datatable/src/lib/ngx-datatable.config.ts
@@ -74,9 +74,9 @@ export type INgxDatatableConfig = NgxDatatableConfig;
  *
  * @param overrides The overrides of the table configuration.
  */
-export function providedNgxDatatableConfig(overrides: AllPartial<NgxDatatableConfig>): Provider {
+export const providedNgxDatatableConfig = (overrides: AllPartial<NgxDatatableConfig>): Provider => {
   return {
     provide: NGX_DATATABLE_CONFIG,
     useValue: overrides
   };
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/camel-case.ts b/projects/ngx-datatable/src/lib/utils/camel-case.ts
@@ -2,7 +2,7 @@
  * Converts strings from something to camel case
  * http://stackoverflow.com/questions/10425287/convert-dash-separated-string-to-camelcase
  */
-export function camelCase(str: string): string {
+export const camelCase = (str: string): string => {
   // Replace special characters with a space
   str = str.replace(/[^a-zA-Z0-9 ]/g, ' ');
   // put a space before an uppercase letter
@@ -15,17 +15,17 @@ export function camelCase(str: string): string {
     .toLowerCase();
 
   // uppercase characters preceded by a space or number
-  str = str.replace(/([ 0-9]+)([a-zA-Z])/g, function (a, b, c) {
+  str = str.replace(/([ 0-9]+)([a-zA-Z])/g, (a, b, c) => {
     return b.trim() + c.toUpperCase();
   });
 
   return str;
-}
+};
 
 /**
  * Converts strings from camel case to words
  * http://stackoverflow.com/questions/7225407/convert-camelcasetext-to-camel-case-text
  */
-export function deCamelCase(str: string): string {
+export const deCamelCase = (str: string): string => {
   return str.replace(/([A-Z])/g, match => ` ${match}`).replace(/^./, match => match.toUpperCase());
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/column-helper.ts b/projects/ngx-datatable/src/lib/utils/column-helper.ts
@@ -9,10 +9,10 @@ import { getterForProp } from './column-prop-getters';
 import { id } from './id';
 import { orderByComparator } from './sort';
 
-export function toInternalColumn<T extends Row>(
+export const toInternalColumn = <T extends Row>(
   columns: TableColumn<T>[] | QueryList<DataTableColumnDirective<T>>,
   defaultColumnWidth = 150
-): TableColumnInternal<T>[] {
+): TableColumnInternal<T>[] => {
   let hasTreeColumn = false;
   // TS fails to infer the type here.
   return (columns as TableColumn<T>[]).map(column => {
@@ -45,4 +45,4 @@ export function toInternalColumn<T extends Row>(
       treeToggleTemplate: column.treeToggleTemplate
     } as TableColumnInternal; // TS cannot cast here
   });
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/column-prop-getters.ts b/projects/ngx-datatable/src/lib/utils/column-prop-getters.ts
@@ -7,15 +7,15 @@ export type ValueGetter = (obj: any, prop: TableColumnProp) => any;
 /**
  * Always returns the empty string ''
  */
-export function emptyStringGetter(): string {
+export const emptyStringGetter = (): string => {
   return '';
-}
+};
 
 /**
  * Returns the appropriate getter function for this kind of prop.
  * If prop == null, returns the emptyStringGetter.
  */
-export function getterForProp(prop: TableColumnProp | undefined): ValueGetter {
+export const getterForProp = (prop: TableColumnProp | undefined): ValueGetter => {
   // TODO requires better typing which will also involve adjust TableColum. So postponing it.
   if (prop == null) {
     return emptyStringGetter;
@@ -31,15 +31,15 @@ export function getterForProp(prop: TableColumnProp | undefined): ValueGetter {
       return shallowValueGetter as ValueGetter;
     }
   }
-}
+};
 
 /**
  * Returns the value at this numeric index.
  * @param row array of values
  * @param index numeric index
  * @returns any or '' if invalid index
  */
-export function numericIndexGetter(row: any[], index: number): any {
+export const numericIndexGetter = (row: any[], index: number): any => {
   if (row == null) {
     return '';
   }
@@ -53,15 +53,15 @@ export function numericIndexGetter(row: any[], index: number): any {
     return '';
   }
   return value;
-}
+};
 
 /**
  * Returns the value of a field.
  * (more efficient than deepValueGetter)
  * @param obj object containing the field
  * @param fieldName field name string
  */
-export function shallowValueGetter(obj: any, fieldName: string): any {
+export const shallowValueGetter = (obj: any, fieldName: string): any => {
   if (obj == null) {
     return '';
   }
@@ -74,12 +74,12 @@ export function shallowValueGetter(obj: any, fieldName: string): any {
     return '';
   }
   return value;
-}
+};
 
 /**
  * Returns a deep object given a string. zoo['animal.type']
  */
-export function deepValueGetter(obj: any, path: string): any {
+export const deepValueGetter = (obj: any, path: string): any => {
   if (obj == null) {
     return '';
   }
@@ -109,4 +109,4 @@ export function deepValueGetter(obj: any, path: string): any {
   }
 
   return current;
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/column.ts b/projects/ngx-datatable/src/lib/utils/column.ts
@@ -8,7 +8,7 @@ import {
 /**
  * Returns the columns by pin.
  */
-export function columnsByPin(cols: TableColumnInternal[]) {
+export const columnsByPin = (cols: TableColumnInternal[]) => {
   const ret: TableColumnGroup = {
     left: [],
     center: [],
@@ -28,35 +28,35 @@ export function columnsByPin(cols: TableColumnInternal[]) {
   }
 
   return ret;
-}
+};
 
 /**
  * Returns the widths of all group sets of a column
  */
-export function columnGroupWidths(
+export const columnGroupWidths = (
   groups: TableColumnGroup,
   all: TableColumnInternal[]
-): ColumnGroupWidth {
+): ColumnGroupWidth => {
   return {
     left: columnTotalWidth(groups.left),
     center: columnTotalWidth(groups.center),
     right: columnTotalWidth(groups.right),
     total: Math.floor(columnTotalWidth(all))
   };
-}
+};
 
 /**
  * Calculates the total width of all columns
  */
-export function columnTotalWidth(columns?: TableColumnInternal[]) {
+export const columnTotalWidth = (columns?: TableColumnInternal[]) => {
   return columns?.reduce((total, column) => total + column.width, 0) ?? 0;
-}
+};
 
-export function columnsByPinArr(val: TableColumnInternal[]): PinnedColumns[] {
+export const columnsByPinArr = (val: TableColumnInternal[]): PinnedColumns[] => {
   const colsByPin = columnsByPin(val);
   return [
     { type: 'left' as const, columns: colsByPin.left },
     { type: 'center' as const, columns: colsByPin.center },
     { type: 'right' as const, columns: colsByPin.right }
   ];
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/events.ts b/projects/ngx-datatable/src/lib/utils/events.ts
@@ -4,11 +4,13 @@
  * @param {MouseEvent | TouchEvent} event - The event object from which to extract the position. Can be either a MouseEvent or a TouchEvent.
  * @return {{ x: number, y: number }} An object containing the x and y coordinates of the event relative to the viewport.
  */
-export function getPositionFromEvent(event: MouseEvent | TouchEvent): {
+export const getPositionFromEvent = (
+  event: MouseEvent | TouchEvent
+): {
   clientX: number;
   clientY: number;
   screenX: number;
   screenY: number;
-} {
+} => {
   return event instanceof MouseEvent ? (event as MouseEvent) : (event.changedTouches[0] as Touch);
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/id.ts b/projects/ngx-datatable/src/lib/utils/id.ts
@@ -2,6 +2,6 @@
  * Creates a unique object id.
  * http://stackoverflow.com/questions/6248666/how-to-generate-short-uid-like-ax4j9z-in-js
  */
-export function id() {
+export const id = () => {
   return ('0000' + ((Math.random() * Math.pow(36, 4)) << 0).toString(36)).slice(-4);
-}
+};
diff --git a/projects/ngx-datatable/src/lib/utils/math.ts b/projects/ngx-datatable/src/lib/utils/math.ts
diff --git a/projects/ngx-datatable/src/lib/utils/selection.ts b/projects/ngx-datatable/src/lib/utils/selection.ts
diff --git a/projects/ngx-datatable/src/lib/utils/sort.ts b/projects/ngx-datatable/src/lib/utils/sort.ts
diff --git a/projects/ngx-datatable/src/lib/utils/tree.ts b/projects/ngx-datatable/src/lib/utils/tree.ts
diff --git a/src/app/basic/filter.component.ts b/src/app/basic/filter.component.ts

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,7 @@ export const tsConfig = typescriptEslint.config({`
`52`	`52`	`'@angular-eslint/no-input-rename': ['off'],`
`53`	`53`	`'@angular-eslint/no-output-native': ['off'],`
`54`	`54`	`'@angular-eslint/directive-class-suffix': ['off'],`
`55`		`- '@angular-eslint/no-conflicting-lifecycle': ['off'],`
`56`		`- 'prefer-arrow/prefer-arrow-functions': ['off']`
	`55`	`+ '@angular-eslint/no-conflicting-lifecycle': ['off']`
`57`	`56`	`}`
`58`	`57`	`});`
`59`	`58`