Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electra /eth/v2/validator/aggregate_attestation returning 404s for DENEB #6983

Closed
Bez625 opened this issue Feb 11, 2025 · 2 comments · Fixed by #6984
Closed

Electra /eth/v2/validator/aggregate_attestation returning 404s for DENEB #6983

Bez625 opened this issue Feb 11, 2025 · 2 comments · Fixed by #6984
Assignees
@eserilev
Labels
bug Something isn't working electra Required for the Electra/Prague fork HTTP-API

Comments

@Bez625
Copy link

Bez625 commented Feb 11, 2025 •
edited
Loading

When testing the current proposed lighthouse version for Electra on holesky (deneb) we always get a 404 when calling /eth/v2/validator/aggregate_attestation.

Lighthouse version:

Lighthouse v6.0.1-62a0f25
BLS library: blst
BLS hardware acceleration: true
SHA256 hardware acceleration: true
Allocator: jemalloc (4K)
Profile: release
Specs: mainnet (true), minimal (false), gnosis (false)

Example curl:

curl --header "Content-Type: application/json" --header "Accept: application/json"  --request GET --data '' "http://<lighthouse-node>/eth/v2/validator/aggregate_attestation?slot=3613623&attestation_data_root=0x25cf9b33dbb83a06ee303595348e984d2bcda2dca31658cb3d8632fed339ffbe&committee_index=32"

Example response:

{
  "code": 404,
  "message": "NOT_FOUND: no matching aggregate found",
  "stacktraces": []
}
@eserilev
Copy link
Collaborator

Thanks for the bug report, will get this fixed ASAP

@eserilev eserilev self-assigned this Feb 11, 2025
@eserilev eserilev mentioned this issue Feb 11, 2025
Merged
@eserilev eserilev added electra Required for the Electra/Prague fork bug Something isn't working HTTP-API labels Feb 11, 2025
@eserilev eserilev linked a pull request Feb 11, 2025 that will close this issue
Ensure GET v2/validator/aggregate_attestation is backwards compatible #6984
Merged
mergify bot pushed a commit that referenced this issue Feb 12, 2025
@eserilev
Ensure GET v2/validator/aggregate_attestation is backwards compatib…
ed8086c 
…le (#6984)

Closes #6983


  `GET v2/validator/aggregate_attestation` is not backwards compatible. It only works for post electra attestations. This PR adds backwards compatibility and additional test coverage. We should include this in the upcoming 7.0 beta release if possible
@eserilev
Copy link
Collaborator

Closed in #6984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eserilev eserilev

Labels
bug Something isn't working electra Required for the Electra/Prague fork HTTP-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure GET v2/validator/aggregate_attestation is backwards compatible eserilev/lighthouse
2 participants
@Bez625 @eserilev