[ReviewEntries] Use whitespace filter for non-empty text (#3715)

Author: imnasnainaec

docs/user_guide/docs/goals.es.md

@@ -28,7 +28,8 @@ There are icons at the top of each column to
 
 In a column with predominantly text content (Vernacular, Glosses, Note, or Flag), you can sort alphabetically or filter
 with a text search. By default, the text search is a fuzzy match: it is not case sensitive and it allows for one or two
-typos. If you want exact text matches, use quotes around your filter.
+typos. If you want exact text matches, use quotes around your filter. To show all entries with non-empty text in the
+column, type a space for your filter.
 
 In the Number of Senses column or Pronunciations column, you can sort or filter by the number of senses or recordings
 that entries have. In the Pronunciations column, you can also filter by speaker name.

docs/user_guide/docs/goals.md

@@ -27,7 +27,8 @@ There are icons at the top of each column to
 
 In a column with predominantly text content (Vernacular, Glosses, Note, or Flag), you can sort alphabetically or filter
 with a text search. By default, the text search is a fuzzy match: it is not case sensitive and it allows for one or two
-typos. If you want exact text matches, use quotes around your filter.
+typos. If you want exact text matches, use quotes around your filter. To show all entries with non-empty text in the
+column, type a space for your filter.
 
 In the Number of Senses column or Pronunciations column, you can sort or filter by the number of senses or recordings
 that entries have. In the Pronunciations column, you can also filter by speaker name.

docs/user_guide/docs/goals.zh.md

@@ -27,7 +27,8 @@ There are icons at the top of each column to
 
 In a column with predominantly text content (Vernacular, Glosses, Note, or Flag), you can sort alphabetically or filter
 with a text search. By default, the text search is a fuzzy match: it is not case sensitive and it allows for one or two
-typos. If you want exact text matches, use quotes around your filter.
+typos. If you want exact text matches, use quotes around your filter. To show all entries with non-empty text in the
+column, type a space for your filter.
 
 In the Number of Senses column or Pronunciations column, you can sort or filter by the number of senses or recordings
 that entries have. In the Pronunciations column, you can also filter by speaker name.

src/goals/ReviewEntries/ReviewEntriesTable/filterFn.ts

@@ -36,6 +36,11 @@ export function fuzzyContains(value: string, filter: string): boolean {
 /** Check if string matches filter.
  * If filter quoted, exact match. Otherwise, fuzzy match. */
 export function matchesFilter(value: string, filter: string): boolean {
+  if (filter && !filter.trim()) {
+    // Whitespace-only filter always matches a non-empty value.
+    return !!value;
+  }
+
   filter = filter.trim();
   return isQuoted(filter)
     ? value.includes(filter.substring(1, filter.length - 1).trim())

src/goals/ReviewEntries/ReviewEntriesTable/tests/filterFn.test.ts

@@ -69,6 +69,11 @@ describe("filterFn", () => {
     const filterWrongCase = "HELLO";
     const filterExact = "Hello";
 
+    it("whitespace: matches non-empty value", () => {
+      expect(ff.matchesFilter(value, " ")).toBeTruthy();
+      expect(ff.matchesFilter("", " ")).toBeFalsy();
+    });
+
     it("unquoted: trims whitespace, fuzzy match", () => {
       expect(ff.matchesFilter(value, "goodbye")).toBeFalsy();
       expect(ff.matchesFilter(value, `  ${filterWithTypo}`)).toBeTruthy();
@@ -89,6 +94,12 @@ describe("filterFn", () => {
       mockGetValue.mockReturnValue("Hello world!");
     });
 
+    it("whitespace: matches non-empty value", () => {
+      expect(filterFn(mockRow, mockId, " ")).toBeTruthy();
+      mockGetValue.mockReturnValueOnce("");
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+    });
+
     it("unquoted: trims whitespace, fuzzy match", () => {
       expect(filterFn(mockRow, mockId, "goodbye")).toBeFalsy();
       expect(filterFn(mockRow, mockId, "  H3LLO")).toBeTruthy();
@@ -110,6 +121,14 @@ describe("filterFn", () => {
       ]);
     });
 
+    it("whitespace: matches non-empty definition text", () => {
+      expect(filterFn(mockRow, mockId, " ")).toBeTruthy();
+      mockGetValue.mockReturnValueOnce([newDefinition()]);
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+      mockGetValue.mockReturnValueOnce([]);
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+    });
+
     it("unquoted: trims whitespace, fuzzy match", () => {
       expect(filterFn(mockRow, mockId, "earth")).toBeFalsy();
       expect(filterFn(mockRow, mockId, " wrld\t")).toBeTruthy();
@@ -128,6 +147,14 @@ describe("filterFn", () => {
       mockGetValue.mockReturnValue([newGloss("hello"), newGloss("WORLD")]);
     });
 
+    it("whitespace: matches non-empty gloss text", () => {
+      expect(filterFn(mockRow, mockId, " ")).toBeTruthy();
+      mockGetValue.mockReturnValueOnce([newGloss()]);
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+      mockGetValue.mockReturnValueOnce([]);
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+    });
+
     it("unquoted: trims whitespace, fuzzy match", () => {
       expect(filterFn(mockRow, mockId, "earth")).toBeFalsy();
       expect(filterFn(mockRow, mockId, " wrld\t")).toBeTruthy();
@@ -223,6 +250,12 @@ describe("filterFn", () => {
       mockGetValue.mockReturnValue(newFlag("Hello world!"));
     });
 
+    it("whitespace: matches non-empty flag text", () => {
+      expect(filterFn(mockRow, mockId, " ")).toBeTruthy();
+      mockGetValue.mockReturnValueOnce(newFlag());
+      expect(filterFn(mockRow, mockId, " ")).toBeFalsy();
+    });
+
     it("unquoted: trims whitespace, fuzzy match", () => {
       expect(filterFn(mockRow, mockId, "goodbye")).toBeFalsy();
       expect(filterFn(mockRow, mockId, "  H3LLO")).toBeTruthy();