`GridFieldEditableColumns` doesn't display validation messages in context

[GuySartorelli]

When using GridFieldEditableColumns, if there are validation errors when saving the record the gridfield is on, the validation error messages are displayed against the parent record.

If the parent record has fields with the same name as the record being edited inline, this results in the message displaying against that field on the parent record (e.g. if there is a Title field on the parent record, and validation fails on the Title field of the child record, it looks like the parent record's Title field failed validation).

If the parent record doesn't have the same-named field, the validation message appears at the top of the form, and doesn't indicate what record or field it is for.

This is made worse in CMS 6 due to the increased validation rules (e.g. entering too much text results in a validation error when it didn't used to).

Reproduction steps

This is easiest to reproduce in CMS 6 with userforms:

1. Create a user defined form page
2. Go to the fields tab
3. Enter > 255 characters into any field
4. Save

PRs

• FIX Handle validation exceptions on editable columns #431

[emteknetnz]

I did some investigation into this and I have a now closed PR linked in the description. I think this issue probably needs further refinement. It's non-trival, it's not a simple bugfix, this feels like more on an enhancement with a UX component.

I really don't know what to do here. The reproduction steps here for the userforms form field editor which does use GridFieldEditableColumns, though it that case it will usually insert a DropdownField for ClassName and a TextField for Title. These do not appear to be rendering with field holders, so any attempt to go $field->setMessage('Validation failed'); on it won't do anything. And this is only for userforms, I have no idea what this would do for non userform gridfields

In the userform scenario, what's causing the page "Title" field to receive the validation issue is that a ValidationException is being thrown with "Title" as the field name. The linked PR will namespace this field, however while that stops the page Title field from getting the validation message put on it, it doesn't automatically on to the gridfield. So while the pjax response 'ValidationResult' node will have the correct field name, I don't think this really matters as I think it's the 'CurrentForm' node with all the server rendered HTML that would actually show the error.

[GuySartorelli]

We likely need to do something similar to what was done for elemental. Namespacing the errors is one side - pulling in those namespaced errors and displaying them correctly is the other side.

Is there some additional refinement you think is needed before we can do that?