add create ignore test

Author: dickermoshe

drift_dev/lib/src/lints/custom_lint_plugin.dart

@@ -1,5 +1,6 @@
 import 'package:custom_lint_builder/custom_lint_builder.dart';
 import 'package:drift_dev/src/lints/drift_backend_error_lint.dart';
+import 'package:drift_dev/src/lints/non_null_insert_with_ignore_lint.dart';
 import 'package:drift_dev/src/lints/offset_without_limit_lint.dart';
 import 'package:drift_dev/src/lints/unawaited_futures_in_transaction_lint.dart';
 import 'package:meta/meta.dart';
@@ -11,6 +12,7 @@ class DriftLinter extends PluginBase {
         unawaitedFuturesInMigration,
         unawaitedFuturesInTransaction,
         OffsetWithoutLimit(),
-        DriftBuildErrors()
+        DriftBuildErrors(),
+        NonNullInsertWithIgnore()
       ];
 }

drift_dev/lib/src/lints/non_null_insert_with_ignore_lint.dart

@@ -0,0 +1,60 @@
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/error/error.dart' hide LintCode;
+import 'package:analyzer/error/listener.dart';
+import 'package:custom_lint_builder/custom_lint_builder.dart';
+
+final managerTypeChecker =
+    TypeChecker.fromName('BaseTableManager', packageName: 'drift');
+final insertStatementChecker =
+    TypeChecker.fromName('InsertStatement', packageName: 'drift');
+final insertOrIgnoreChecker =
+    TypeChecker.fromName('InsertMode', packageName: 'drift');
+
+class NonNullInsertWithIgnore extends DartLintRule {
+  NonNullInsertWithIgnore() : super(code: _code);
+
+  static const _code = LintCode(
+    name: 'non_null_insert_with_ignore',
+    problemMessage:
+        '`insertReturning` and `createReturning` will throw an exception if a row isn\'t actually inserted. Use `createReturningOrNull` or `insertReturningOrNull` if you want to ignore conflicts.',
+    errorSeverity: ErrorSeverity.WARNING,
+  );
+
+  @override
+  void run(CustomLintResolver resolver, ErrorReporter reporter,
+      CustomLintContext context) async {
+    context.registry.addMethodInvocation(
+      (node) {
+        if (node.argumentList.arguments.isEmpty) return;
+        switch (node.function) {
+          case SimpleIdentifier func:
+            if (func.name == "insertReturning" ||
+                func.name == "createReturning") {
+              switch (func.parent) {
+                case MethodInvocation func:
+                  final targetType = func.realTarget?.staticType;
+                  if (targetType != null) {
+                    if (managerTypeChecker.isSuperTypeOf(targetType) ||
+                        insertStatementChecker.isExactlyType(targetType)) {
+                      final namedArgs = func.argumentList.arguments
+                          .whereType<NamedExpression>();
+                      for (final arg in namedArgs) {
+                        if (arg.name.label.name == "mode") {
+                          switch (arg.expression) {
+                            case PrefixedIdentifier mode:
+                              if (mode.identifier.name == "insertOrIgnore") {
+                                print("Found insertOrIgnore");
+                                reporter.atNode(node, _code);
+                              }
+                          }
+                        }
+                      }
+                    }
+                  }
+              }
+            }
+        }
+      },
+    );
+  }
+}

drift_dev/test/lint/lint_test.dart

@@ -8,11 +8,8 @@ void main() {
   test('linter', () async {
     final workingDir = p.join(p.current, 'test/lint/test_pkg');
     expect(
-        await Process.run('dart', ['pub', 'get'], workingDirectory: workingDir)
-            .then((v) => v.exitCode),
-        0);
-    expect(
-        await Process.run('custom_lint', ['--fatal-infos', '--fatal-warnings'],
+        await Process.run('dart',
+                ['run', 'custom_lint', '--fatal-infos', '--fatal-warnings'],
                 workingDirectory: workingDir)
             .then((v) => v.exitCode),
         0);

drift_dev/test/lint/test_pkg/lib/db.dart

@@ -33,8 +33,20 @@ class TestDatabase extends _$TestDatabase {
       () async {
         // expect_lint: unawaited_futures_in_transaction
         into(users).insert(UsersCompanion.insert(name: 'name'));
+        await into(users).insert(UsersCompanion.insert(name: 'name'));
       },
     );
+    await into(users).insertReturning(UsersCompanion.insert(name: 'name'),
+        mode: InsertMode.insertOrIgnore);
+    // expect_lint: non_null_insert_with_ignore
+    await managers.users
+        .createReturning((o) => o(name: "hi"), mode: InsertMode.insertOrIgnore);
+    await into(users).insertReturningOrNull(UsersCompanion.insert(name: 'name'),
+        mode: InsertMode.insertOrIgnore);
+    await managers.users.createReturningOrNull((o) => o(name: "hi"),
+        mode: InsertMode.insertOrIgnore);
+    await into(users).insertReturning(UsersCompanion.insert(name: 'name'));
+    await managers.users.createReturning((o) => o(name: "hi"));
   }
 
   @override