Skip to content

Commit bb4aa2c

Browse files
authored
fix(CodeEditor): fix Codemirror being initialized twice (#40)
* fix(CodeEditor): fix Codemirror being initialized twice * build: reset react 18
1 parent 17e5197 commit bb4aa2c

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

docs/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import CodeView from '../src';
55

66
import './styles/index.less';
77

8+
// eslint-disable-next-line @typescript-eslint/no-var-requires
89
const example = require('./example.md');
910

1011
const App = () => {

src/CodeEditor.tsx

+8-7
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,14 @@ const CodeEditor = React.forwardRef((props: CodeEditorProps, ref: React.Ref<HTML
4949

5050
setInitialized(true);
5151

52-
editor.current = CodeMirror.fromTextArea(textareaRef.current, {
53-
...defaultEditorConfig,
54-
...editorConfig
55-
});
56-
editor.current.on('change', handleChange);
57-
58-
onInitialized?.(editor.current);
52+
if (!editor.current) {
53+
editor.current = CodeMirror.fromTextArea(textareaRef.current, {
54+
...defaultEditorConfig,
55+
...editorConfig
56+
});
57+
editor.current.on('change', handleChange);
58+
onInitialized?.(editor.current);
59+
}
5960
});
6061
// eslint-disable-next-line react-hooks/exhaustive-deps
6162
}, []);

0 commit comments

Comments
 (0)