Skip to content

Commit 6e08a76

Browse files
authored
bugfix: without this, create_symlink would only be called based on the CLI argument, not the .yml setting (#509)
1 parent 10cf953 commit 6e08a76

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

shpc/main/modules/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,6 @@ def check_symlink(self, module_dir, symlink=False):
212212
Given an install command, if --symblink is provided make sure we have
213213
a symlink_base defined in settings and the directory exists.
214214
"""
215-
# Global override to arg
216-
symlink = self.settings.symlink_tree is True or symlink
217215
if not symlink:
218216
return
219217

@@ -379,6 +377,9 @@ def install(self, name, tag=None, symlink=False, **kwargs):
379377
subfolder = os.path.join(uri, tag.name)
380378
container_dir = self.container.container_dir(subfolder)
381379

380+
# Global override to arg
381+
symlink = self.settings.symlink_tree is True or symlink
382+
382383
# Cut out early if symlink desired or already exists
383384
self.check_symlink(module_dir, symlink)
384385
shpc.utils.mkdirp([module_dir, container_dir])

0 commit comments

Comments
 (0)