Skip to content

Commit e8f37df

Browse files
committed
try doing uninstall after test, and looking at docker/podman images before and after
Signed-off-by: vsoch <[email protected]>
1 parent 67517dc commit e8f37df

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

.github/workflows/test.yml

+33
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ jobs:
7777
printf "\n\shpc test ============================================\n"
7878
shpc test python:3.9.5-alpine
7979
80+
if [ "${{ matrix.container_tech }}" == "podman" ]; then
81+
printf "Podman images before install\n"
82+
podman images
83+
elif [ "${{ matrix.container_tech }}" == "docker" ]; then
84+
printf "Docker images before install\n"
85+
docker images
86+
done
87+
8088
shpc install python:3.9.5-alpine
8189
8290
module use ./modules
@@ -101,6 +109,14 @@ jobs:
101109
grep --quiet 'Python 3.9.5' test_output
102110
rm test_output
103111
shpc uninstall --force python:3.9.5-alpine
112+
113+
if [ "${{ matrix.container_tech }}" == "podman" ]; then
114+
printf "Podman images after uninstall\n"
115+
podman images
116+
elif [ "${{ matrix.container_tech }}" == "docker" ]; then
117+
printf "Docker images after uninstall\n"
118+
docker images
119+
done
104120
105121
- name: Run python module tests (tcsh)
106122
shell: tcsh -e {0}
@@ -120,6 +136,14 @@ jobs:
120136
shpc config set module_sys:${{ matrix.module }}
121137
shpc config set enable_tty:false
122138
139+
if [ "${{ matrix.container_tech }}" == "podman" ]; then
140+
printf "Podman images before install\n"
141+
podman images
142+
elif [ "${{ matrix.container_tech }}" == "docker" ]; then
143+
printf "Docker images before install\n"
144+
docker images
145+
done
146+
123147
shpc install python:3.9.5-alpine
124148
125149
module use ./modules
@@ -144,3 +168,12 @@ jobs:
144168
grep --quiet 'Python 3.9.5' test_output
145169
rm test_output
146170
shpc uninstall --force python:3.9.5-alpine
171+
172+
if [ "${{ matrix.container_tech }}" == "podman" ]; then
173+
printf "Podman images after uninstall\n"
174+
podman images
175+
elif [ "${{ matrix.container_tech }}" == "docker" ]; then
176+
printf "Docker images after uninstall\n"
177+
docker images
178+
done
179+

shpc/main/client.py

+1
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ def cleanup(tmpdir):
177177
if stage:
178178
logger.info(tmpdir)
179179
else:
180+
self.uninstall("%s:%s" % (module_name, tag), force=True)
180181
cleanup(tmpdir)
181182

182183
def check(self, module_name):

0 commit comments

Comments
 (0)