Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of the module.tcl files? #453

Closed
jacquikeane opened this issue Nov 18, 2021 · 9 comments
Closed

Naming of the module.tcl files? #453

jacquikeane opened this issue Nov 18, 2021 · 9 comments

Comments

@jacquikeane
Copy link

Is there a reason why the module files are all named module.tcl in the software/version directory (first screenshot) instead of named as the version in the software directory (second screenshot)? The latter is the naming convention on all the HPC environments I have used to date.

Screenshot from 2021-11-18 16-17-30
Screenshot from 2021-11-18 16-20-46

Also, is there anyway to configure the directory structure for organising the module files on disk? For example, remove the name of the registry?

@vsoch
Copy link
Member

vsoch commented Nov 18, 2021

It was mostly a choice based on my inexperience with managing modules, and also so that they were programmatically discoverable (and note that I wanted a directory to put other files for the module)! I would definitely be open to discussion and then work to refactoring this to 1. make the naming more akin to conventions, and 2. still maintain discoverability and organization. cc @marcodelapierre

@jacquikeane
Copy link
Author

Yes I though that was the reason! (I see a default script for defining environment variables included with each application). Perhaps having all the files that are currently generated stored somewhere outside of the modules base directory and then under the modules base directory creating the hierarchy as it is now but symlinking to the module.tcl as the version would be an option? (this is a random suggestion, I have not looked the code or know enough about modules to know if symlinked files are an option)

With regard my other question on the organisational hierarchy/directory structure under the modules base directory, it would be really great to be able to configure this. I will open another issue to explain the use case.

@vsoch
Copy link
Member

vsoch commented Nov 18, 2021

I think we can figure out something to try! I'll bring @marcodelapierre into the conversation - note he's in Australia so I normally chat with him later in the evening. We will work on this soon!

@marcodelapierre
Copy link
Contributor

marcodelapierre commented Nov 25, 2021

See my comments in #456

@muffato
Copy link
Contributor

muffato commented Jun 23, 2022

This has been addressed by the views.

@vsoch
Copy link
Member

vsoch commented Jun 23, 2022

I also tested not using the name, and it seemed to break things so I'm afraid I don't have a suggested fix for this (beyond views). Does anyone else have thoughts or should we close?

@vsoch vsoch closed this as completed Jun 23, 2022
@vsoch vsoch reopened this Jun 23, 2022
@vsoch
Copy link
Member

vsoch commented Jun 23, 2022

oops did not mean to close 😆

@marcodelapierre
Copy link
Contributor

As @muffato mentioned, I think we've addressed this one with the views feature, isn't it?

@vsoch
Copy link
Member

vsoch commented Jun 23, 2022

Works for me! @georgiastuart please ping / open a new issue to discuss anything further. Closing!

@vsoch vsoch closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants