Skip to content

Conversation

@catinodeh
Copy link

The company I work for needs to work with Custom Objects in Hubspot so I implemented a first working version and added integration tests to all new methods I added.

I still need to do some small code adjustments and I will add the README change on it. Please review this PR first so it doesn't get longer and longer.

@catinodeh
Copy link
Author

Just noticed that in order for the tests to pass, a custom object must be added to the "HUBSPOT_API_KEY" account and changed in the CustomObjectHubSpotEntityExtended class. I'm sure the tests failed because of that.

@catinodeh catinodeh mentioned this pull request Apr 11, 2022
@catinodeh
Copy link
Author

@nover Hey Nicklas, do you have an idea when you can take a look at both PRs I raised?

@nover
Copy link
Contributor

nover commented Apr 19, 2022

Hi @catinodeh

Thanks for the contributions, been a bit busy and on easter break.
I'll have a look on your PRs in the coming days :)

@nover
Copy link
Contributor

nover commented Aug 17, 2022

@catinodeh I realise that a significant amount of time has passed since you posted this PR, I'm sorry about that.

Is this feature still relevant for you, and potentially for others using HubSpot? If yes, then I think we should pick it up again and see if we can get it finalized.

@nover nover added enhancement pending-author Feedback is pending from the author of a PR labels Aug 17, 2022
Copy link
Contributor

@nover nover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to summon author.

@ntulip-qpac
Copy link

@catinodeh I realise that a significant amount of time has passed since you posted this PR, I'm sorry about that.

Is this feature still relevant for you, and potentially for others using HubSpot? If yes, then I think we should pick it up again and see if we can get it finalized.

I am interested in this library and custom objects since our company will likely. leverage at least one custom object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement pending-author Feedback is pending from the author of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants