Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Edit file" is grayed out in Step 1 #245

Open
hadder94 opened this issue Dec 9, 2024 · 5 comments
Open

[Bug] "Edit file" is grayed out in Step 1 #245

hadder94 opened this issue Dec 9, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@hadder94
Copy link

hadder94 commented Dec 9, 2024

Summary

In step 1 of the tutorial, the "Edit file" option for "index.md" file is grayed out when creating a PR.

How to reproduce

  1. Open the pull requests tab.
  2. Click New pull request, for the branches to compare, select base: main and compare: start-markdown.
  3. Click Create pull request.
  4. In this pull request, go to the Files changed tab. We made an empty file index.md for you.
  5. Select Edit file from the three dotted ... menu in the upper right corner of the file view on index.md.
Screenshot 2024-12-09 at 3 48 30 PM
@hadder94 hadder94 added the bug Something isn't working label Dec 9, 2024
@hadder94 hadder94 changed the title [Bug] "Edit file [Bug] "Edit file" is grayed out in Step 1 Dec 9, 2024
@sarnett24
Copy link

It turns out that you need to push the Pull Request once more for the edit functionality to show. https://github.com/orgs/skills/discussions/354
image

mjbear's comment is how I found it.

@nguyenalex836
Copy link

@hadder94 Thank you for raising the flag on this! I'll get this triaged for the team to review ✨

@aflacake
Copy link

After merge it, when committing the file index.md as per the step request (added headings). Workflow doesn't continue to next step.

@f0lded-c0de
Copy link

f0lded-c0de commented Feb 22, 2025

Just for those still struggling with it, I realized you don't need to do it in the pull request, you can just go edit the file in the start-markdown branch normally, commit the change, and the course will advance to step 2 normally. (I don't really know why the course absolutely wants us to do it in the pull request ? We're just editing files, so why not just tell us to... Go edit the file normally ?)
I did the same for the following steps as no matter what I did the edit is grayed out.

To expand on the base issue (because I stil don't understand the issue... Although I am pretty new to GitHub and all this), if I click on View file instead, the edit button (the little pencil) tells me "You must be on a branch to make or propose changes to this file". And ideed, if I look to the left, the drop-down menu indicating the branch indicates that I'm not on a branch, but on the last commit, the one where Github Action updates the course. And I can switch to the start-markdown branch from there and now I can edit the file.

Edit : Just finished the course, and doing it like that you'll still need to create a pull request and merge it for the last step to validate (when it asks you to merge the pull request). But no need to make the edits in the pull request, it's just for the merge.

@aflacake
Copy link

@f0lded-c0de
Their steps need to be clarified. Thanks for answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants