[API-3583] Track tx costs (#57)

* change tx price oracle to be slightly more chain agnostic, pull config when getting gas cost instead of passing in coin gecko id

* add tx cost to submitted txs table and update queries

* move evmrpc tx price oracle to chain agnostic oracle package and allow users to call gas cost uusdc

* parse fee out of tx result to use as gas cost

* rename evm tx price oracle -> price oracle

* update interface for calling tx price oracle from hyperlane client

* get gas cost in uusdc when verifying a submitted tx

* add rebalance_transfer_id column to submitted txs table

* insert fund rebalancer txs into submitted txs table

* erc20 approval before gas cost estimation

* move evm tx price oracle to generic oracle package to not be evm specific

* add db queries to support fund rebalancer to add txns to submitted txs table

* fund rebalancer adds txs to submitted txs table

* add test for fund rebalancer adding txns to submitted txns table

* fix imports

* dont link erc20 approval txs to rebalance txs in fund rebalancer

* change fee parsing to decode tx auth info bytes and return gas denom fee

* return an error if fee for gas denom is not found in cosmos tx result

* fix db migration naming and make rebalance_transfer_id a foreign key

* pass chainid to tx price oracle

Author: mattac21

.mockery.yml

@@ -6,7 +6,9 @@ packages:
     interfaces:
       EVMRPCClientManager:
       EVMChainRPC:
-      IOracle:
+  github.com/skip-mev/go-fast-solver/shared/oracle:
+    interfaces:
+      TxPriceOracle:
   github.com/skip-mev/go-fast-solver/shared/http:
     interfaces:
       Client:

cmd/solver/main.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/skip-mev/go-fast-solver/gasmonitor"
 
+	"github.com/skip-mev/go-fast-solver/shared/oracle"
 	"github.com/skip-mev/go-fast-solver/shared/txexecutor/cosmos"
 	"github.com/skip-mev/go-fast-solver/shared/txexecutor/evm"
 
@@ -97,9 +98,9 @@ func main() {
 	rateLimitedClient := utils.DefaultRateLimitedHTTPClient(3)
 	coingeckoClient := coingecko.NewCoingeckoClient(rateLimitedClient, "https://api.coingecko.com/api/v3/", "")
 	cachedCoinGeckoClient := coingecko.NewCachedPriceClient(coingeckoClient, 15*time.Minute)
-	evmTxPriceOracle := evmrpc.NewOracle(cachedCoinGeckoClient)
+	txPriceOracle := oracle.NewOracle(cachedCoinGeckoClient)
 
-	hype, err := hyperlane.NewMultiClientFromConfig(ctx, evmManager, keyStore, evmTxPriceOracle, evmTxExecutor)
+	hype, err := hyperlane.NewMultiClientFromConfig(ctx, evmManager, keyStore, txPriceOracle, evmTxExecutor)
 	if err != nil {
 		lmt.Logger(ctx).Fatal("creating hyperlane multi client from config", zap.Error(err))
 	}
@@ -144,7 +145,7 @@ func main() {
 	})
 
 	eg.Go(func() error {
-		r, err := fundrebalancer.NewFundRebalancer(ctx, keyStore, skipgo, evmManager, db.New(dbConn), evmTxPriceOracle, evmTxExecutor)
+		r, err := fundrebalancer.NewFundRebalancer(ctx, keyStore, skipgo, evmManager, db.New(dbConn), txPriceOracle, evmTxExecutor)
 		if err != nil {
 			return fmt.Errorf("creating fund rebalancer: %w", err)
 		}
@@ -153,7 +154,7 @@ func main() {
 	})
 
 	eg.Go(func() error {
-		r, err := txverifier.NewTxVerifier(ctx, db.New(dbConn), clientManager)
+		r, err := txverifier.NewTxVerifier(ctx, db.New(dbConn), clientManager, txPriceOracle)
 		if err != nil {
 			return err
 		}

cmd/solvercli/cmd/relay.go

@@ -7,6 +7,7 @@ import (
 	"encoding/json"
 	"time"
 
+	"github.com/skip-mev/go-fast-solver/shared/oracle"
 	"github.com/skip-mev/go-fast-solver/shared/txexecutor/evm"
 
 	"os/signal"
@@ -97,9 +98,9 @@ var relayCmd = &cobra.Command{
 		rateLimitedClient := utils.DefaultRateLimitedHTTPClient(3)
 		coingeckoClient := coingecko.NewCoingeckoClient(rateLimitedClient, "https://api.coingecko.com/api/v3/", "")
 		cachedCoinGeckoClient := coingecko.NewCachedPriceClient(coingeckoClient, 15*time.Minute)
-		evmTxPriceOracle := evmrpc.NewOracle(cachedCoinGeckoClient)
+		txPriceOracle := oracle.NewOracle(cachedCoinGeckoClient)
 		evmTxExecutor := evm.DefaultEVMTxExecutor()
-		hype, err := hyperlane.NewMultiClientFromConfig(ctx, evmrpc.NewEVMRPCClientManager(), keyStore, evmTxPriceOracle, evmTxExecutor)
+		hype, err := hyperlane.NewMultiClientFromConfig(ctx, evmrpc.NewEVMRPCClientManager(), keyStore, txPriceOracle, evmTxExecutor)
 		if err != nil {
 			lmt.Logger(ctx).Error("Error creating hyperlane multi client from config", zap.Error(err))
 		}

db/gen/db/models.go

@@ -25,4 +25,4 @@ WHERE order_settlement_id IS NOT NULL;
 
 CREATE UNIQUE INDEX submitted_txs_chain_tx_key
 ON submitted_txs(chain_id, tx_hash)
-WHERE order_settlement_id IS NULL;
+WHERE order_settlement_id IS NULL;

db/gen/db/transactions.sql.go

@@ -0,0 +1 @@
+ALTER TABLE submitted_txs DROP COLUMN tx_cost_uusdc;

db/migrations/000004_add_submitted_tx_table.up.sql

@@ -0,0 +1 @@
+ALTER TABLE submitted_txs ADD tx_cost_uusdc TEXT;

db/migrations/000008_add_tx_price_cost_column_to_submitted_tx.down.sql

@@ -0,0 +1 @@
+ALTER TABLE submitted_txs DROP COLUMN rebalance_transfer_id;

db/migrations/000008_add_tx_price_cost_column_to_submitted_tx.up.sql

@@ -0,0 +1 @@
+ALTER TABLE submitted_txs ADD COLUMN rebalance_transfer_id INT REFERENCES rebalance_transfers(id);