EVM Transaction Approval Amount Change From UInt256 Max -> requiredApproval.amount

[yu-jeffy]

Hi,

Currently when approving the tokens for a EVM transaction, it attempts to approve the max uint 256 amount of tokens. It should approve the amount specified in the transaction itself, to avoid giving permission to extra tokens than needed for the transaction.

Here is the diff that solved my problem:

diff --git a/node_modules/@skip-go/core/dist/index.js b/node_modules/@skip-go/core/dist/index.js
index 1ae6767..a06491a 100644
--- a/node_modules/@skip-go/core/dist/index.js
+++ b/node_modules/@skip-go/core/dist/index.js
@@ -1310,7 +1310,7 @@ var SkipRouter = class {
           address: requiredApproval.tokenContract,
           abi: erc20ABI,
           functionName: "approve",
-          args: [requiredApproval.spender, viem.maxUint256],
+          args: [requiredApproval.spender, requiredApproval.amount],
           chain: signer.chain
         });
         const receipt2 = yield extendedSigner.waitForTransactionReceipt({

This issue body was partially generated by patch-package.

Thanks,
Jeffy

[codingki]

Hi @yu-jeffy Appreciate the feedback. Feel free to PR to this repo. We can add it for the next release

[VorobevSA]

I support, from the users side the current behavior looks like bad faith, change the request to the amount requested, it will be more user friendly

[codingki]

Released in @skip-go/client@0.5.2