Skip to content

Commit 082b679

Browse files
committed
logging in visualization
1 parent 0d54192 commit 082b679

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

src/programflow-visualization/frontend/frontend.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { ExtensionContext } from 'vscode';
2+
import * as vscode from 'vscode';
23
import { VisualizationPanel } from './visualization_panel';
34
import { MessagePort } from 'worker_threads';
45
import * as TraceCache from '../trace_cache';
@@ -7,6 +8,7 @@ let panel: VisualizationPanel | undefined = undefined;
78

89
export async function startFrontend(
910
context: ExtensionContext,
11+
outChannel: vscode.OutputChannel,
1012
filePath: string,
1113
fileHash: string,
1214
tracePort: MessagePort | null): Promise<Failure | undefined> {
@@ -16,7 +18,7 @@ export async function startFrontend(
1618
}
1719

1820
panel?.dispose();
19-
panel = await VisualizationPanel.getVisualizationPanel(context, filePath, fileHash, trace, tracePort);
21+
panel = await VisualizationPanel.getVisualizationPanel(context, outChannel, filePath, fileHash, trace, tracePort);
2022
if (!panel) {
2123
return failure("Frontend couldn't be initialized!");
2224
}

src/programflow-visualization/frontend/visualization_panel.ts

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,17 @@ export class VisualizationPanel {
1818
private _trace: FrontendTrace;
1919
private _traceIndex: number;
2020
private _tracePortSelfClose: boolean;
21+
private _outChannel: vscode.OutputChannel;
2122

22-
private constructor(context: vscode.ExtensionContext, filePath: string, fileHash: string, trace: BackendTrace, tracePort: MessagePort | null) {
23+
private constructor(
24+
context: vscode.ExtensionContext,
25+
outChannel: vscode.OutputChannel,
26+
filePath: string,
27+
fileHash: string,
28+
trace: BackendTrace,
29+
tracePort: MessagePort | null
30+
) {
31+
this._outChannel = outChannel;
2332
this._fileHash = fileHash;
2433
this._tracePort = tracePort;
2534
this._backendTrace = { trace: trace, complete: trace.length > 0 };
@@ -74,8 +83,8 @@ export class VisualizationPanel {
7483
if (this._panel?.active) {
7584
this.updateLineHighlight();
7685
}
77-
}, undefined, context.subscriptions);
78-
86+
}, undefined, context.subscriptions);
87+
7988

8089
// Message Receivers
8190
this._panel.webview.onDidReceiveMessage(
@@ -118,12 +127,13 @@ export class VisualizationPanel {
118127

119128
public static async getVisualizationPanel(
120129
context: vscode.ExtensionContext,
130+
outChannel: vscode.OutputChannel,
121131
filePath: string,
122132
fileHash: string,
123133
trace: BackendTrace,
124134
tracePort: MessagePort | null
125135
): Promise<VisualizationPanel | undefined> {
126-
return new VisualizationPanel(context, filePath, fileHash, trace, tracePort);
136+
return new VisualizationPanel(context, outChannel, filePath, fileHash, trace, tracePort);
127137
}
128138

129139
// TODO: Look if Typescript is possible OR do better documentation in all files

src/programflow-visualization/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export function getProgFlowVizCallback(context: vscode.ExtensionContext, outChan
2929
tracePort = startBackend(context, file, outChannel);
3030
}
3131

32-
const result = await startFrontend(context, file.fsPath, fileHash, tracePort);
32+
const result = await startFrontend(context, outChannel, file.fsPath, fileHash, tracePort);
3333
if (result) {
3434
await vscode.window.showErrorMessage("Error ProgramFlow-Visualization: " + result.errorMessage);
3535
return;

src/programflow-visualization/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/**
22
* For better readable code
33
*/
44
type Try = Success | Failure;

0 commit comments

Comments
 (0)