Merge pull request #195 from skogsbaer/sw/filenames

fix bug with filenames of stdlib modules

Author: skogsbaer

python/code/wypp/exceptionHandler.py

@@ -43,8 +43,9 @@ def handleCurrentException(exit=True, removeFirstTb=False, file=sys.stderr):
     frameList = (stacktrace.tbToFrameList(tb) if tb is not None else [])
     if frameList and removeFirstTb:
         frameList = frameList[1:]
-    isBug = not isWyppError and not isinstance(val, SyntaxError) and \
-        len(frameList) > 0 and stacktrace.isWyppFrame(frameList[-1])
+    isSyntaxError = isinstance(val, SyntaxError)
+    lastFrameIsWypp = len(frameList) > 0 and stacktrace.isWyppFrame(frameList[-1])
+    isBug = not isWyppError and not isSyntaxError and lastFrameIsWypp
     stackSummary = stacktrace.limitTraceback(frameList, extra, not isBug and not isDebug())
     header = False
     for x in stackSummary.format():
@@ -62,6 +63,7 @@ def handleCurrentException(exit=True, removeFirstTb=False, file=sys.stderr):
         for x in traceback.format_exception_only(etype, val):
             file.write(x)
     if isBug:
+        debug(f'isWyppError={isWyppError}, isSyntaxError={isSyntaxError}, lastFrameIsWypp={lastFrameIsWypp}')
         file.write(f'BUG: the error above is most likely a bug in WYPP!')
     if exit:
         utils.die(1)

python/code/wypp/instrument.py

@@ -140,19 +140,23 @@ def find_spec(
             target: types.ModuleType | None = None,
         ) -> ModuleSpec | None:
 
+        debug(f'Consulting InstrumentingFinder.find_spec for fullname={fullname}')
         # 1) The fullname is the name of the main module. This might be a dotted name such as x.y.z.py
         #    so we have special logic here
         fp = os.path.join(self.modDir, f"{fullname}.py")
         if self.mainModName == fullname and os.path.isfile(fp):
             loader = InstrumentingLoader(fullname, fp)
-            return spec_from_file_location(fullname, fp, loader=loader)
+            spec = spec_from_file_location(fullname, fp, loader=loader)
+            debug(f'spec for {fullname}: {spec}')
+            return spec
         # 2) The fullname is a prefix of the main module. We want to load main modules with
         #    dotted names such as x.y.z.py, hence we synthesize a namespace pkg
         #    e.g. if 'x.y.z.py' exists and we're asked for 'x', return a package spec.
         elif self.mainModName.startswith(fullname + '.'):
             spec = importlib.machinery.ModuleSpec(fullname, loader=None, is_package=True)
             # Namespace package marker (PEP 451)
             spec.submodule_search_locations = []
+            debug(f'spec for {fullname}: {spec}')
             return spec
         # 3) Fallback: use the original PathFinder
         spec = self._origFinder.find_spec(fullname, path, target)
@@ -191,10 +195,19 @@ def setupFinder(modDir: str, modName: str, extraDirs: list[str], typechecking: b
         # Create and install our custom finder
         instrumenting_finder = InstrumentingFinder(finder, modDir, modName, extraDirs)
         sys.meta_path.insert(0, instrumenting_finder)
+        debug(f'Installed instrument finder {instrumenting_finder}')
+
+        alreadyLoaded = sys.modules.get(modName)
+        if alreadyLoaded:
+            sys.modules.pop(modName, None)
+            importlib.invalidate_caches()
 
         try:
             yield
         finally:
+            if alreadyLoaded:
+                sys.modules[modName] = alreadyLoaded
+
             # Remove our custom finder when exiting the context
             if instrumenting_finder in sys.meta_path:
                 sys.meta_path.remove(instrumenting_finder)

python/code/wypp/location.py

@@ -201,6 +201,10 @@ def getResultTypeLocation(self) -> Optional[Loc]:
     @abc.abstractmethod
     def getParamSourceLocation(self, paramName: str) -> Optional[Loc]:
         pass
+    @property
+    @abc.abstractmethod
+    def isAsync(self) -> bool:
+        pass
 
 class StdCallableInfo(CallableInfo):
     """
@@ -276,6 +280,10 @@ def getParamSourceLocation(self, paramName: str) -> Optional[Loc]:
                        res.end_lineno,
                        res.end_col_offset)
 
+    @property
+    def isAsync(self) -> bool:
+        node = self._findDef()
+        return isinstance(node, ast.AsyncFunctionDef)
 
 def classFilename(cls) -> str | None:
     """Best-effort path to the file that defined `cls`."""
@@ -315,6 +323,9 @@ def getParamSourceLocation(self, paramName: str) -> Optional[Loc]:
             return Loc(file, node.lineno, node.col_offset, node.end_lineno, node.end_col_offset)
         else:
             return None
+    @property
+    def isAsync(self) -> bool:
+        return False
 
 def locationOfArgument(fi: inspect.FrameInfo, idxOrName: int | str) -> Optional[Loc]:
     """

python/code/wypp/runCode.py

@@ -34,7 +34,7 @@ def __init__(self, mod, properlyImported):
 @dataclass
 class RunSetup:
     def __init__(self, pathDir: str, args: list[str]):
-        self.pathDir = pathDir
+        self.pathDir = os.path.abspath(pathDir)
         self.args = args
         self.sysPathInserted = False
         self.oldArgs = sys.argv
@@ -64,12 +64,30 @@ def prepareLib(onlyCheckRunnable, enableTypeChecking):
                        quiet=onlyCheckRunnable)
     return libDefs
 
+def debugModule(name):
+    if name in sys.modules:
+        m = sys.modules["copy"]
+        print(f"Module {name} already loaded from:", getattr(m, "__file__", None))
+    print("CWD:", os.getcwd())
+    print("sys.path[0]:", sys.path[0])
+    print("First few sys.path entries:")
+    for p in sys.path[:5]:
+        print("  ", p)
+
+    spec = importlib.util.find_spec(name)
+    print("Resolved spec:", spec)
+    if spec:
+        print("Origin:", spec.origin)
+        print("Loader:", type(spec.loader).__name__)
+
 def runCode(fileToRun, globals, doTypecheck=True, extraDirs=None) -> dict:
     if not extraDirs:
         extraDirs = []
     modName = os.path.basename(os.path.splitext(fileToRun)[0])
     with instrument.setupFinder(os.path.dirname(fileToRun), modName, extraDirs, doTypecheck):
         sys.dont_write_bytecode = True
+        if DEBUG:
+            debugModule(modName)
         res = runpy.run_module(modName, init_globals=globals, run_name='__wypp__', alter_sys=False)
         return res
 

python/code/wypp/runner.py

@@ -66,9 +66,14 @@ def main(globals, argList=None):
             sys.exit(1)
 
     fileToRun: str = args.file
+    if not os.path.exists(fileToRun):
+        printStderr(f'File {fileToRun} does not exist')
+        sys.exit(1)
     if args.changeDir:
-        os.chdir(os.path.dirname(fileToRun))
+        d = os.path.dirname(fileToRun)
+        os.chdir(d)
         fileToRun = os.path.basename(fileToRun)
+        debug(f'Changed directory to {d}, fileToRun={fileToRun}')
 
     isInteractive = args.interactive
     version = versionMod.readVersion()
@@ -81,13 +86,15 @@ def main(globals, argList=None):
 
     libDefs = runCode.prepareLib(onlyCheckRunnable=args.checkRunnable, enableTypeChecking=args.checkTypes)
 
-    with (runCode.RunSetup(os.path.dirname(fileToRun), [fileToRun] + restArgs),
+    runDir = os.path.dirname(fileToRun)
+    with (runCode.RunSetup(runDir, [fileToRun] + restArgs),
           paths.projectDir(os.path.abspath(os.getcwd()))):
         globals['__name__'] = '__wypp__'
         sys.modules['__wypp__'] = sys.modules['__main__']
         loadingFailed = False
         try:
             verbose(f'running code in {fileToRun}')
+            debug(f'sys.path: {sys.path}')
             globals['__file__'] = fileToRun
             globals = runCode.runStudentCode(fileToRun, globals, args.checkRunnable,
                                              doTypecheck=args.checkTypes, extraDirs=args.extraDirs)

python/code/wypp/typecheck.py

@@ -126,6 +126,8 @@ def raiseArgMismatch():
 
 def checkReturn(sig: inspect.Signature, returnFrame: Optional[inspect.FrameInfo],
                 result: Any, info: location.CallableInfo, cfg: CheckCfg) -> None:
+    if info.isAsync:
+        return
     t = sig.return_annotation
     if isEmptyAnnotation(t):
         t = None

python/file-test-data/basics/async2_ok.out

@@ -0,0 +1,4 @@
+coroutine object
+At start of meaningOfLife: a
+At end of meaningOfLife: a
+42

python/file-test-data/basics/async2_ok.py

@@ -0,0 +1,24 @@
+from typing import *
+import types
+import asyncio
+from datetime import datetime
+
+def debug(msg):
+    print(msg)
+
+async def meaningOfLife(x: str) -> int:
+    debug(f'At start of meaningOfLife: {x}')
+    await asyncio.sleep(0.0001)
+    debug(f'At end of meaningOfLife: {x}')
+    return 42
+
+async def run() -> None:
+    a = meaningOfLife('a')
+    debug('coroutine object')
+    n = await a
+    debug(n)
+
+def main():
+    asyncio.run(run())
+
+main()

python/file-test-data/basics/copy.out

@@ -0,0 +1 @@
+Hello copy

python/file-test-data/basics/copy.py

@@ -0,0 +1,4 @@
+# WYPP_TEST_CONFIG: {"args": ["--change-directory"], "exitCode": 0}
+
+# This file intentionally has the same name as a file from the stdlib
+print('Hello copy')