EffectsKt.LaunchedEffect is deprecated; but only one override deprecated causes Lint warning

[kozaxinan]

LaunchedEffect and DisposableEffect without key parameters are deprecated. Eventhough we dont use any of those deprecated functions, Deprecated lint check fails.

[ZacSweers]

@kozaxinan can you please add a bit more detail or a reproducible sample

[kozaxinan]

Hi, you are right. Original description doesn't contain much details.

With @ZeeshanShabbir, we created a project to reproduce. https://github.com/kozaxinan/lint-investigation

run ./gradlew :app:lintDebug

Details

Kotlin 2.0.20
Compose 2024.09.02
AGP 8.6.1
Slack lint 0.7.4

here is the lint result

[kozaxinan]

I also tried to write an unit test but tests are working as expected.

  @Test
  fun `kotlin-sourced non-deprecated overridden method use has no warning in kotlin`() {
    lint()
      .files(
        DEPRECATED_METHOD_OVERRIDE_KOTLIN,
        kotlin(
            """
                  package slack.test

                  import slack.test.thisIsDeprecated

                  class TestClass {

                    public fun doStuff() {
                      thisIsDeprecated() {}

                      thisIsDeprecated("This is NOT deprecated overridden version.") {}
                    }
                  }
                """
          )
          .indented(),
      )
      .issues(DeprecatedAnnotationDetector.ISSUE_DEPRECATED_CALL)
      .run()
      .expect(
        """
          src/slack/test/TestClass.kt:8: Warning: slack.test.TestKt.thisIsDeprecated is deprecated; consider using an alternative. [DeprecatedCall]
              thisIsDeprecated() {}
              ~~~~~~~~~~~~~~~~~~~~~
          0 errors, 1 warnings
        """
          .trimIndent()
      )
  }

  private val DEPRECATED_METHOD_OVERRIDE_KOTLIN =
    kotlin(
      """
          package slack.test

          import kotlin.Deprecated
          import kotlin.DeprecationLevel

          // This deprecated-error function shadows the varargs overload so that the varargs version
          // is not used without key parameters.
          @Deprecated("", level = DeprecationLevel.ERROR)
          public fun thisIsDeprecated(
            block: suspend () -> Unit
          ) = Unit

          public fun thisIsDeprecated(param: Any?, block: suspend () -> Unit) {}
          public fun thisIsDeprecated(param: Any?, param1: Any?, block: suspend () -> Unit) {}
          public fun thisIsDeprecated(vararg params: Any?, block: suspend () -> Unit) {}
        """
    )

[ZacSweers]

Deduping into #268. Can you try with Lint 8.7.0+ to see if that resolves anything?

[kozaxinan]

8.7.0 didnt change the result.