Fix (Disallow|Require)TrailingComma*Sniff to handle null parenthesis pointers

Author: HonzaCZ

SlevomatCodingStandard/Sniffs/Functions/DisallowTrailingCommaInCallSniff.php

@@ -53,7 +53,7 @@ public function process(File $phpcsFile, int $parenthesisOpenerPointer): void
 		$parenthesisCloserPointer = $tokens[$parenthesisOpenerPointer]['parenthesis_closer'];
 		$pointerBeforeParenthesisCloser = TokenHelper::findPreviousEffective($phpcsFile, $parenthesisCloserPointer - 1);
 
-		if ($tokens[$pointerBeforeParenthesisCloser]['code'] !== T_COMMA) {
+		if ($pointerBeforeParenthesisCloser === null || $tokens[$pointerBeforeParenthesisCloser]['code'] !== T_COMMA) {
 			return;
 		}
 

SlevomatCodingStandard/Sniffs/Functions/DisallowTrailingCommaInClosureUseSniff.php

@@ -50,7 +50,7 @@ public function process(File $phpcsFile, int $functionPointer): void
 			$useParenthesisOpenerPointer,
 		);
 
-		if ($tokens[$pointerBeforeUseParenthesisCloser]['code'] !== T_COMMA) {
+		if ($pointerBeforeUseParenthesisCloser === null || $tokens[$pointerBeforeUseParenthesisCloser]['code'] !== T_COMMA) {
 			return;
 		}
 

SlevomatCodingStandard/Sniffs/Functions/DisallowTrailingCommaInDeclarationSniff.php

@@ -38,7 +38,7 @@ public function process(File $phpcsFile, int $functionPointer): void
 			$parenthesisOpenerPointer,
 		);
 
-		if ($tokens[$pointerBeforeParenthesisCloser]['code'] !== T_COMMA) {
+		if ($pointerBeforeParenthesisCloser === null || $tokens[$pointerBeforeParenthesisCloser]['code'] !== T_COMMA) {
 			return;
 		}
 

SlevomatCodingStandard/Sniffs/Functions/RequireTrailingCommaInCallSniff.php

@@ -60,7 +60,9 @@ public function process(File $phpcsFile, int $parenthesisOpenerPointer): void
 
 		$parenthesisCloserPointer = $tokens[$parenthesisOpenerPointer]['parenthesis_closer'];
 
-		if ($tokens[$parenthesisOpenerPointer]['line'] === $tokens[$parenthesisCloserPointer]['line']) {
+		if ($parenthesisCloserPointer === null
+			|| $tokens[$parenthesisOpenerPointer]['line'] === $tokens[$parenthesisCloserPointer]['line']
+		) {
 			return;
 		}
 

SlevomatCodingStandard/Sniffs/Functions/RequireTrailingCommaInClosureUseSniff.php

@@ -48,7 +48,10 @@ public function process(File $phpcsFile, int $functionPointer): void
 		$useParenthesisOpenerPointer = $tokens[$usePointer]['parenthesis_opener'];
 		$useParenthesisCloserPointer = $tokens[$usePointer]['parenthesis_closer'];
 
-		if ($tokens[$useParenthesisOpenerPointer]['line'] === $tokens[$useParenthesisCloserPointer]['line']) {
+		if ($useParenthesisOpenerPointer === null
+			|| $useParenthesisCloserPointer === null
+			|| $tokens[$useParenthesisOpenerPointer]['line'] === $tokens[$useParenthesisCloserPointer]['line']
+		) {
 			return;
 		}
 

SlevomatCodingStandard/Sniffs/Functions/RequireTrailingCommaInDeclarationSniff.php

@@ -37,7 +37,10 @@ public function process(File $phpcsFile, int $functionPointer): void
 		$parenthesisOpenerPointer = $tokens[$functionPointer]['parenthesis_opener'];
 		$parenthesisCloserPointer = $tokens[$functionPointer]['parenthesis_closer'];
 
-		if ($tokens[$parenthesisOpenerPointer]['line'] === $tokens[$parenthesisCloserPointer]['line']) {
+		if ($parenthesisOpenerPointer === null
+			|| $parenthesisCloserPointer === null
+			|| $tokens[$parenthesisOpenerPointer]['line'] === $tokens[$parenthesisCloserPointer]['line']
+		) {
 			return;
 		}